[breakpad] Add windows tools #38671
[breakpad] Add windows tools #38671
Conversation
jimwang118
added
the
category:port-feature
|
Testing under local Windows did not generate dump_syms, sym_upload, google_converter. |
Use vcpkg install breakpad[tools] - triplet x64-windows? |
I'm very sorry, it's my fault that I didn't add the feature during the test. Retested and passed. |
|
Compile test pass with following triplets: |
ports/breakpad/CMakeLists.txt
Outdated
| @@ -178,6 +178,29 @@ if(INSTALL_TOOLS) | |||
| src/tools/linux/core_handler/core_handler.cc) | |||
| target_link_libraries(core_handler PRIVATE libbreakpad_client) | |||
| install(TARGETS core_handler DESTINATION bin) | |||
| elseif(WIN32) | |||
| set(CMAKE_GENERATOR_PLATFORM ${VCPKG_TARGET_ARCHITECTURE}) | |||
There was a problem hiding this comment.
Isn't it initialized correctly?
"The value of this variable should never be modified by project code."
https://cmake.org/cmake/help/latest/variable/CMAKE_GENERATOR_PLATFORM.html
There was a problem hiding this comment.
Why do we need this patch?
| # (although the friendly name of that is C++ profiling tools). The toolset is the most likely target. | ||
| set(PROGRAMFILES_X86 "ProgramFiles(x86)") | ||
| execute_process( | ||
| COMMAND "$ENV{${PROGRAMFILES_X86}}/Microsoft Visual Studio/Installer/vswhere.exe" -latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property installationPath |
There was a problem hiding this comment.
@BillyONeal pointed out that this command may choose a DIA SDK instance not related to the compiler used
data-queue
removed
the
info:reviewed
SHA512s are updated for each updated download.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.