Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg baseline][qt5-base] Add option disable feature gssapi to fix ci baseline #38670

Merged
merged 37 commits into from May 17, 2024
Merged

[vcpkg baseline][qt5-base] Add option disable feature gssapi to fix ci baseline #38670

merged 37 commits into from May 17, 2024

Conversation

JonLiu1993
Copy link
Member

@JonLiu1993 JonLiu1993 commented May 10, 2024 •
edited

Fixes regression: https://dev.azure.com/vcpkg/public/_build/results?buildId=102737&view=results

REGRESSION: lunarg-vulkantools:x64-linux failed with BUILD_FAILED
REGRESSION: qt5-serialbus:x64-linux failed with BUILD_FAILED

Error:

/usr/bin/ld: /mnt/vcpkg-ci/b/krb5/x64-linux-dbg/lib/gssapi/krb5/../../.././../src/krb5-1-8a38cd677f.clean/src/lib/gssapi/krb5/export_name.c:61: undefined reference to `krb5_free_context'

Add option --gssapi=no to disable use feature gssapi
Remove

lunarg-vulkantools:x64-linux=fail
qt5-serialbus:x64-linux=fail

from ci.baseline.txt

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. requires:testing Needs tests added before merging labels May 10, 2024
@JonLiu1993 JonLiu1993 changed the title [libsoup] disable the automatic detection of krb5 [cibaseline][libsoup] disable the automatic detection of krb5 May 10, 2024
@JonLiu1993 JonLiu1993 removed the requires:testing Needs tests added before merging label May 11, 2024
@JonLiu1993 JonLiu1993 changed the title [cibaseline][libsoup] disable the automatic detection of krb5 [vcpkg baseline][libsoup] disable the automatic detection of krb5 May 11, 2024
@JonLiu1993 JonLiu1993 marked this pull request as ready for review May 11, 2024 07:09
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label May 11, 2024
@JonLiu1993 JonLiu1993 marked this pull request as draft May 11, 2024 09:46
@JonLiu1993 JonLiu1993 changed the title [vcpkg baseline][libsoup] disable the automatic detection of krb5 [WIP][vcpkg baseline][libsoup] disable the automatic detection of krb5 May 13, 2024
@JonLiu1993 JonLiu1993 added the requires:testing Needs tests added before merging label May 13, 2024
@jimwang118 jimwang118 removed the info:reviewed Pull Request changes follow basic guidelines label May 13, 2024
dg0yt
dg0yt reviewed May 13, 2024
View reviewed changes
ports/curl/vcpkg.json Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 changed the title [WIP][vcpkg baseline][libsoup] disable the automatic detection of krb5 [WIP][vcpkg baseline][libsoup] testing May 13, 2024
@JonLiu1993 JonLiu1993 mentioned this pull request May 16, 2024
Merged
7 tasks
@JonLiu1993 JonLiu1993 changed the title [WIP][vcpkg baseline][libsoup] testing [WIP][vcpkg baseline]testing May 16, 2024
@JonLiu1993 JonLiu1993 changed the title [WIP][vcpkg baseline]testing [vcpkg baseline][qt5-base] Add option disable function gssapi to fix ci baseline May 17, 2024
@JonLiu1993 JonLiu1993 removed the requires:testing Needs tests added before merging label May 17, 2024
@JonLiu1993 JonLiu1993 changed the title [vcpkg baseline][qt5-base] Add option disable function gssapi to fix ci baseline [vcpkg baseline][qt5-base] Add option disable use feature gssapi to fix ci baseline May 17, 2024
@JonLiu1993 JonLiu1993 changed the title [vcpkg baseline][qt5-base] Add option disable use feature gssapi to fix ci baseline [vcpkg baseline][qt5-base] Add option disable feature gssapi to fix ci baseline May 17, 2024
@JonLiu1993 JonLiu1993 marked this pull request as ready for review May 17, 2024 09:14
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label May 17, 2024
@data-queue data-queue merged commit 5b55ba9 into microsoft:master May 17, 2024
17 checks passed
@JonLiu1993 JonLiu1993 deleted the dev/Jon/libsoup branch May 20, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talregev talregev talregev left review comments

@dg0yt dg0yt dg0yt left review comments

@data-queue data-queue data-queue approved these changes

Assignees

@jimwang118 jimwang118

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JonLiu1993 @talregev @dg0yt @data-queue @jimwang118