[cpprestsdk] fix bad define in header for clang #38659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
definint dllimport is *bad* and breaks clang, and since this is in maintaince mode they aren't going to fix it. Refs: microsoft/cpprestsdk#1710 llvm/llvm-project#53269
Neumann-A
reviewed
May 9, 2024
| #define _ASYNCRTIMP_TYPEINFO | ||
| #else // ^^^ _NO_ASYNCRTIMP ^^^ // vvv !_NO_ASYNCRTIMP vvv | ||
| #ifdef _ASYNCRT_EXPORT | ||
| +#ifdef _WIN32 |
There was a problem hiding this comment.
I wonder if these checks should be #ifdef _MSC_VER instead.
__declspec(dllexport) is a compiler specific attribute not a platform specific one.
There was a problem hiding this comment.
The attribute is also implemented by mingw, and widely used with _WIN32. So it is okay IMO.
There was a problem hiding this comment.
Also implemented by clang.
MonicaLiu0311
added
the
category:port-bug
MonicaLiu0311
approved these changes
May 20, 2024
MonicaLiu0311
added
the
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining
dllimportis bad and breaks clang, and since this is in maintaince mode they aren't going to fix it.This had the ability to blow up projects before, but newer zlib versions use
__has_declspec_attribute, so that makes it impossible to even build cpprestsdk on systems like these (I'm on Fedora 40).Refs:
microsoft/cpprestsdk#1710
llvm/llvm-project#53269
./vcpkg x-add-version --alland committing the result.