[rush] Update the functionality that runs external lifecycle processes to be async. #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
D4N14L
reviewed
Sep 27, 2023
| result = child_process.spawnSync(command + '.cmd', args, options); | ||
| const stdoutBuffers: string[] = []; | ||
| process.stdout?.on('data', (chunk) => { | ||
| stdoutBuffers.push(chunk.toString()); |
There was a problem hiding this comment.
Should we care about encoding here?
|
|
||
| const stderrBuffers: string[] = []; | ||
| process.stderr?.on('data', (chunk) => { | ||
| stderrBuffers.push(chunk.toString()); |
|
|
||
| let error: Error | undefined; | ||
| try { | ||
| await once(process, 'close'); |
There was a problem hiding this comment.
There was some outcome that we came to with which event we should wait on before exiting. Is this the one we settled on?
| (result.stderr ? result.stderr.toString() : '') | ||
| ); | ||
| if (status) { | ||
| throw new Error(`The command failed with exit code ${status}\n${stderr}`); |
There was a problem hiding this comment.
Did non-zero exit codes always throw spawnSync? I know some tools intentionally return non-zero exit codes. Whatever we do here should be compatible with what spawnSync does.
iclanton
force-pushed
the
refactor-executeCommand
branch
2 times, most recently
from
e853889
to
a16f097
Compare
D4N14L
reviewed
Mar 30, 2024
| if (!this._targetBranchName) { | ||
| this._targetBranchName = this._targetBranchParameter.value || this._git.getRemoteDefaultBranch(); | ||
| this._targetBranchName = | ||
| this._targetBranchParameter.value || (await this._git.getRemoteDefaultBranch()); |
| @@ -10,8 +10,8 @@ describe('CLI', () => { | |||
| const workingDir: string = '/'; | |||
| const startPath: string = path.resolve(__dirname, '../../../lib-commonjs/start.js'); | |||
|
|
|||
| expect(() => { | |||
| Utilities.executeCommand({ | |||
| expect(async () => { | |||
There was a problem hiding this comment.
Do you have to await these expects?
| (result.stderr ? result.stderr.toString() : '') | ||
| ); | ||
| const stderr: string = stderrBuffers.join(''); | ||
| const stdout: string = stdoutBuffers.join(''); |
There was a problem hiding this comment.
I feel like a lot of this should exist under the Executable class... but it may not? (On mobile)
iclanton
force-pushed
the
refactor-executeCommand
branch
from
a16f097
to
0062d82
Compare
iclanton
force-pushed
the
refactor-executeCommand
branch
from
0062d82
to
ebe2934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
executeCommandand related functions to be async. This is in preparation for some follow-up work to mergeexecuteCommandAndProcessOutputWithRetryAsyncinto theexecuteCommandAsyncfunction.How it was tested
This change needs some more testing.