Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to pass custom epicMiddleware to epicManager #141

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Lucklyric
Copy link

It is common to have an epicMiddleware that includes dependencies.
In the current observable extension, it creates a default epicMiddleware which will not work for users with custom epicMiddleware.
In this PR, I simply added an argument to getObservableExtension to allow user to pass custom epicMiddleware to epicManger in the extension.

export function getObservableExtension(_epicMiddleware: EpicMiddleware<any>): IExtension;

@msftclas
Copy link

msftclas commented Apr 19, 2020

CLA assistant check
All CLA requirements met.

@olegshilov
Copy link

any news here?

@LFFATE
Copy link

LFFATE commented Jun 24, 2020

well. it's also will solve my problem #145
So waiting for review this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants