Move to default branch #7231
Draft
Move to default branch #7231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwunderl
approved these changes
Aug 4, 2020
|
@pelikhan what is pending in this PR? |
|
Backend need to be able to pull the default branch when not specified. Switch template to use "main" be default? Otherwise lots of testing. |
pelikhan
commented
May 8, 2021
| export function isDefaultBranch(branch: string, repo?: GitRepo) { | ||
| if (repo && repo.defaultBranch) | ||
| return branch === repo.defaultBranch; | ||
| return /^(main|master)$/.test(branch); |
jwunderl
reviewed
May 11, 2021
| const defaultBranch = pxt.github.isDefaultBranch(branch) | ||
| const latest = defaultBranch ? "latest" : "git-" + branch | ||
| // upload locs on build on default or releases | ||
| const apiStringBranchRx: (t: string) => boolean = ((t:string) => new RegExp(pxt.appTarget.uploadApiStringsBranchRx).test(t)) |
There was a problem hiding this comment.
Suggested change
| const apiStringBranchRx: (t: string) => boolean = ((t:string) => new RegExp(pxt.appTarget.uploadApiStringsBranchRx).test(t)) | |
| const apiStringBranchRx: (t: string) => boolean = ((t: string) => new RegExp(pxt.appTarget.uploadApiStringsBranchRx).test(t)) |
to make the linter happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't assume that master is the default branch. Cleaning up to remove this assumption.