Remove unnecessary async stuff

microsoft · May 9, 2024 · c169068 · c169068
1 parent a58b3a3
commit c169068
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 14 deletions.
diff --git a/teachertool/src/components/CatalogOverlay.tsx b/teachertool/src/components/CatalogOverlay.tsx
@@ -14,11 +14,7 @@ import { announceToScreenReader } from "../transforms/announceToScreenReader";
 import { FocusTrap } from "react-common/components/controls/FocusTrap";
 import { logError } from "../services/loggingService";
 import { ErrorCode } from "../types/errorCode";
-import {
-    addExpandedCatalogTagAsync,
-    getExpandedCatalogTags,
-    removeExpandedCatalogTagAsync,
-} from "../services/storageService";
+import { addExpandedCatalogTag, getExpandedCatalogTags, removeExpandedCatalogTag } from "../services/storageService";
 import css from "./styling/CatalogOverlay.module.scss";
 
 interface CatalogHeaderProps {
@@ -163,9 +159,9 @@ const CatalogList: React.FC = () => {
 
     function onTagExpandToggled(tag: string, expanded: boolean) {
         if (expanded) {
-            /* await */ addExpandedCatalogTagAsync(tag);
+            addExpandedCatalogTag(tag);
         } else {
-            /* await */ removeExpandedCatalogTagAsync(tag);
+            removeExpandedCatalogTag(tag);
         }
     }
 
@@ -177,7 +173,7 @@ const CatalogList: React.FC = () => {
     let expandedTags = getExpandedCatalogTags();
     if (!expandedTags) {
         // If we haven't saved an expanded set, default expand the first one.
-        addExpandedCatalogTagAsync(tags[0]);
+        addExpandedCatalogTag(tags[0]);
         expandedTags = [tags[0]];
     }
 

diff --git a/teachertool/src/services/storageService.ts b/teachertool/src/services/storageService.ts
@@ -206,32 +206,32 @@ export function getExpandedCatalogTags(): string[] | undefined {
     }
 }
 
-export async function setExpandedCatalogTagsAsync(tags: string[]) {
+export function setExpandedCatalogTags(tags: string[]) {
     try {
         setValue(EXPANDED_CATALOG_TAGS_KEY, JSON.stringify(tags));
     } catch (e) {
         logError(ErrorCode.localStorageWriteError, e);
     }
 }
 
-export async function addExpandedCatalogTagAsync(tag: string) {
+export function addExpandedCatalogTag(tag: string) {
     let expandedTags = getExpandedCatalogTags();
     if (!expandedTags) {
         expandedTags = [];
     }
     expandedTags.push(tag);
-    await setExpandedCatalogTagsAsync(expandedTags);
+    setExpandedCatalogTags(expandedTags);
 }
 
-export async function removeExpandedCatalogTagAsync(tag: string) {
+export function removeExpandedCatalogTag(tag: string) {
     let expandedTags = getExpandedCatalogTags();
     if (!expandedTags) {
-        await setExpandedCatalogTagsAsync([]);
+        setExpandedCatalogTags([]);
     } else {
         const index = expandedTags.indexOf(tag);
         if (index !== -1) {
             expandedTags.splice(index, 1);
-            await setExpandedCatalogTagsAsync(expandedTags);
+            setExpandedCatalogTags(expandedTags);
         }
     }
 }