Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial Anchor overloads with position and rotation offsets #279

Merged
merged 5 commits into from
Mar 24, 2023
Merged

Spatial Anchor overloads with position and rotation offsets #279

merged 5 commits into from
Mar 24, 2023

Conversation

austinbhale
Copy link
Contributor

@austinbhale austinbhale commented Mar 21, 2023

These overloads coincide with the overloads for SpatialAnchor.TryCreateRelativeTo since they don't accept optional parameters as well.

@sandrist
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@austinbhale austinbhale marked this pull request as draft March 21, 2023 23:27
@austinbhale austinbhale marked this pull request as ready for review March 22, 2023 03:17
@austinbhale
Copy link
Contributor Author

Thanks for all the helpful feedback! Hope this will get some usage. Let me know if there's anything else you think might be nice to add.

@sandrist
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@sandrist sandrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sandrist
Copy link
Contributor

Thanks for all the helpful feedback! Hope this will get some usage. Let me know if there's anything else you think might be nice to add.

Thanks for the contribution!

@sandrist
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sandrist sandrist merged commit cb2651f into microsoft:master Mar 24, 2023
@austinbhale austinbhale deleted the patch-1 branch March 24, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants