Merged PR 43330: Release 0.12.53.2

Release 0.12.53.2 to master Related work items: #126416
microsoft · Jun 17, 2020 · fc6bdfd · fc6bdfd
1 parent dc11ff3
commit fc6bdfd
Show file tree

Hide file tree

Showing 467 changed files with 14,689 additions and 9,567 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -0,0 +1 @@
+*.sh text eol=lf
diff --git a/Build/Microsoft.Psi.ruleset b/Build/Microsoft.Psi.ruleset
@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
-<RuleSet Name="Microsoft Psi Released Project Rules" Description="These rules are used for released Psi projects." ToolsVersion="15.0">
+<RuleSet Name="Microsoft Psi Released Project Rules" Description="These rules are used for released Psi projects." ToolsVersion="16.0">
+  <Include Path="Security.ruleset" Action="Default" />
   <Rules AnalyzerId="Microsoft.Analyzers.ManagedCodeAnalysis" RuleNamespace="Microsoft.Rules.Managed">
     <Rule Id="CA1001" Action="Warning" />
     <Rule Id="CA1009" Action="Warning" />
@@ -8,6 +9,7 @@
     <Rule Id="CA1049" Action="Warning" />
     <Rule Id="CA1060" Action="Warning" />
     <Rule Id="CA1061" Action="Warning" />
+    <Rule Id="CA1063" Action="None" />
     <Rule Id="CA1065" Action="Warning" />
     <Rule Id="CA1301" Action="Warning" />
     <Rule Id="CA1400" Action="Warning" />
@@ -71,7 +73,7 @@
     <Rule Id="SA1009" Action="None" />
     <Rule Id="SA1124" Action="None" />
     <Rule Id="SA1305" Action="Warning" />
-    <Rule Id="SA1504" Action="None" />
     <Rule Id="SA1407" Action="None" />
+    <Rule Id="SA1504" Action="None" />
   </Rules>
 </RuleSet>
diff --git a/Build/Sample.Psi.ruleset b/Build/Sample.Psi.ruleset
@@ -1,9 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
-<RuleSet Name="Microsoft Psi Sample Project Rules" Description="These rules are used for Psi sample projects." ToolsVersion="10.0">
-  <Localization ResourceAssembly="Microsoft.VisualStudio.CodeAnalysis.RuleSets.Strings.dll" ResourceBaseName="Microsoft.VisualStudio.CodeAnalysis.RuleSets.Strings.Localized">
-    <Name Resource="MinimumRecommendedRules_Name" />
-    <Description Resource="MinimumRecommendedRules_Description" />
-  </Localization>
+<RuleSet Name="Microsoft Psi Sample Project Rules" Description="These rules are used for Psi sample projects." ToolsVersion="15.0">
+  <Include Path="Security.ruleset" Action="Default" />
   <Rules AnalyzerId="Microsoft.Analyzers.ManagedCodeAnalysis" RuleNamespace="Microsoft.Rules.Managed">
     <Rule Id="CA1001" Action="Warning" />
     <Rule Id="CA1009" Action="Warning" />
@@ -12,7 +9,7 @@
     <Rule Id="CA1049" Action="Warning" />
     <Rule Id="CA1060" Action="Warning" />
     <Rule Id="CA1061" Action="Warning" />
-    <Rule Id="CA1063" Action="Warning" />
+    <Rule Id="CA1063" Action="None" />
     <Rule Id="CA1065" Action="Warning" />
     <Rule Id="CA1301" Action="Warning" />
     <Rule Id="CA1400" Action="Warning" />
@@ -74,9 +71,9 @@
     <Rule Id="SA1124" Action="None" />
     <Rule Id="SA1305" Action="Warning" />
     <Rule Id="SA1401" Action="None" />
+    <Rule Id="SA1402" Action="None" />
     <Rule Id="SA1407" Action="None" />
     <Rule Id="SA1504" Action="None" />
     <Rule Id="SA1652" Action="None" />
-    <Rule Id="SA1402" Action="None" />
   </Rules>
 </RuleSet>
diff --git a/Build/Security.ruleset b/Build/Security.ruleset
@@ -0,0 +1,207 @@
+<?xml version="1.0" encoding="utf-8"?>
+<RuleSet Name="Microsoft Psi Security Rules" Description="This rule set contains required and recommended security rules." ToolsVersion="16.0">
+  <Rules AnalyzerId="Microsoft.CodeAnalysis.VersionCheckAnalyzer" RuleNamespace="Microsoft.CodeAnalysis.VersionCheckAnalyzer">
+    <Rule Id="CA9999" Action="None" />
+  </Rules>
+  <Rules AnalyzerId="Microsoft.CodeQuality.Analyzers" RuleNamespace="Microsoft.CodeQuality.Analyzers">
+    <Rule Id="CA1000" Action="None" />
+    <Rule Id="CA1010" Action="None" />
+    <Rule Id="CA1016" Action="None" />
+    <Rule Id="CA1018" Action="None" />
+    <Rule Id="CA1021" Action="None" />
+    <Rule Id="CA1028" Action="None" />
+    <Rule Id="CA1030" Action="None" />
+    <Rule Id="CA1031" Action="None" />
+    <Rule Id="CA1034" Action="None" />
+    <Rule Id="CA1036" Action="None" />
+    <Rule Id="CA1040" Action="None" />
+    <Rule Id="CA1041" Action="None" />
+    <Rule Id="CA1043" Action="None" />
+    <Rule Id="CA1044" Action="None" />
+    <Rule Id="CA1051" Action="None" />
+    <Rule Id="CA1052" Action="None" />
+    <Rule Id="CA1054" Action="None" />
+    <Rule Id="CA1055" Action="None" />
+    <Rule Id="CA1056" Action="None" />
+    <Rule Id="CA1061" Action="None" />
+    <Rule Id="CA1062" Action="None" />
+    <Rule Id="CA1063" Action="None" />
+    <Rule Id="CA1064" Action="None" />
+    <Rule Id="CA1066" Action="None" />
+    <Rule Id="CA1067" Action="None" />
+    <Rule Id="CA1068" Action="None" />
+    <Rule Id="CA1069" Action="None" />
+    <Rule Id="CA1707" Action="None" />
+    <Rule Id="CA1710" Action="None" />
+    <Rule Id="CA1712" Action="None" />
+    <Rule Id="CA1714" Action="None" />
+    <Rule Id="CA1715" Action="None" />
+    <Rule Id="CA1716" Action="None" />
+    <Rule Id="CA1717" Action="None" />
+    <Rule Id="CA1720" Action="None" />
+    <Rule Id="CA1721" Action="None" />
+    <Rule Id="CA1724" Action="None" />
+    <Rule Id="CA1801" Action="None" />
+    <Rule Id="CA1802" Action="None" />
+    <Rule Id="CA1806" Action="None" />
+    <Rule Id="CA1812" Action="None" />
+    <Rule Id="CA1814" Action="None" />
+    <Rule Id="CA1815" Action="None" />
+    <Rule Id="CA1819" Action="None" />
+    <Rule Id="CA1821" Action="None" />
+    <Rule Id="CA1822" Action="None" />
+    <Rule Id="CA1823" Action="None" />
+    <Rule Id="CA2007" Action="None" />
+    <Rule Id="CA2011" Action="None" />
+    <Rule Id="CA2119" Action="None" />
+    <Rule Id="CA2211" Action="None" />
+    <Rule Id="CA2214" Action="None" />
+    <Rule Id="CA2219" Action="None" />
+    <Rule Id="CA2225" Action="None" />
+    <Rule Id="CA2226" Action="None" />
+    <Rule Id="CA2227" Action="None" />
+    <Rule Id="CA2231" Action="None" />
+    <Rule Id="CA2244" Action="None" />
+    <Rule Id="CA2245" Action="None" />
+    <Rule Id="CA2246" Action="None" />
+  </Rules>
+  <Rules AnalyzerId="Microsoft.CodeQuality.CSharp.Analyzers" RuleNamespace="Microsoft.CodeQuality.CSharp.Analyzers">
+    <Rule Id="Async001" Action="None" />
+    <Rule Id="Async002" Action="None" />
+    <Rule Id="Async003" Action="None" />
+    <Rule Id="Async004" Action="None" />
+    <Rule Id="Async005" Action="None" />
+    <Rule Id="Async006" Action="None" />
+    <Rule Id="CA1001" Action="None" />
+    <Rule Id="CA1032" Action="None" />
+    <Rule Id="CA1065" Action="None" />
+    <Rule Id="CA1200" Action="None" />
+    <Rule Id="CA1507" Action="None" />
+    <Rule Id="CA2200" Action="None" />
+    <Rule Id="CA2234" Action="None" />
+  </Rules>
+  <Rules AnalyzerId="Microsoft.CodeQuality.VisualBasic.Analyzers" RuleNamespace="Microsoft.CodeQuality.VisualBasic.Analyzers">
+    <Rule Id="Async001" Action="None" />
+    <Rule Id="Async002" Action="None" />
+    <Rule Id="Async003" Action="None" />
+    <Rule Id="Async004" Action="None" />
+    <Rule Id="Async005" Action="None" />
+    <Rule Id="Async006" Action="None" />
+    <Rule Id="CA1001" Action="None" />
+    <Rule Id="CA1003" Action="None" />
+    <Rule Id="CA1019" Action="None" />
+    <Rule Id="CA1032" Action="None" />
+    <Rule Id="CA1065" Action="None" />
+    <Rule Id="CA1200" Action="None" />
+    <Rule Id="CA1507" Action="None" />
+    <Rule Id="CA2200" Action="None" />
+    <Rule Id="CA2218" Action="None" />
+    <Rule Id="CA2224" Action="None" />
+    <Rule Id="CA2234" Action="None" />
+  </Rules>
+  <Rules AnalyzerId="Microsoft.NetCore.Analyzers" RuleNamespace="Microsoft.NetCore.Analyzers">
+    <Rule Id="CA1303" Action="None" />
+    <Rule Id="CA1304" Action="None" />
+    <Rule Id="CA1305" Action="None" />
+    <Rule Id="CA1307" Action="None" />
+    <Rule Id="CA1308" Action="None" />
+    <Rule Id="CA1401" Action="None" />
+    <Rule Id="CA1816" Action="None" />
+    <Rule Id="CA1820" Action="None" />
+    <Rule Id="CA1826" Action="None" />
+    <Rule Id="CA1827" Action="None" />
+    <Rule Id="CA1828" Action="None" />
+    <Rule Id="CA2000" Action="None" />
+    <Rule Id="CA2002" Action="None" />
+    <Rule Id="CA2008" Action="None" />
+    <Rule Id="CA2009" Action="None" />
+    <Rule Id="CA2012" Action="None" />
+    <Rule Id="CA2013" Action="None" />
+    <Rule Id="CA2100" Action="None" />
+    <Rule Id="CA2101" Action="None" />
+    <Rule Id="CA2201" Action="None" />
+    <Rule Id="CA2208" Action="None" />
+    <Rule Id="CA2213" Action="None" />
+    <Rule Id="CA2215" Action="None" />
+    <Rule Id="CA2216" Action="None" />
+    <Rule Id="CA2229" Action="None" />
+    <Rule Id="CA2235" Action="None" />
+    <Rule Id="CA2237" Action="None" />
+    <Rule Id="CA2241" Action="None" />
+    <Rule Id="CA2242" Action="None" />
+    <Rule Id="CA2243" Action="None" />
+    <Rule Id="CA2301" Action="Warning" />
+    <Rule Id="CA2302" Action="Warning" />
+    <Rule Id="CA2305" Action="Warning" />
+    <Rule Id="CA2311" Action="Warning" />
+    <Rule Id="CA2312" Action="Warning" />
+    <Rule Id="CA2315" Action="Warning" />
+    <Rule Id="CA2321" Action="Warning" />
+    <Rule Id="CA2322" Action="Info" />
+    <Rule Id="CA2327" Action="Warning" />
+    <Rule Id="CA2328" Action="Warning" />
+    <Rule Id="CA2329" Action="Warning" />
+    <Rule Id="CA2330" Action="Warning" />
+    <Rule Id="CA3001" Action="Info" />
+    <Rule Id="CA3002" Action="Info" />
+    <Rule Id="CA3003" Action="Info" />
+    <Rule Id="CA3004" Action="Info" />
+    <Rule Id="CA3005" Action="Info" />
+    <Rule Id="CA3006" Action="Info" />
+    <Rule Id="CA3007" Action="Info" />
+    <Rule Id="CA3008" Action="Info" />
+    <Rule Id="CA3009" Action="Info" />
+    <Rule Id="CA3010" Action="Info" />
+    <Rule Id="CA3011" Action="Info" />
+    <Rule Id="CA3012" Action="Info" />
+    <Rule Id="CA5358" Action="Warning" />
+    <Rule Id="CA5359" Action="Info" />
+    <Rule Id="CA5360" Action="None" />
+    <Rule Id="CA5363" Action="None" />
+    <Rule Id="CA5365" Action="None" />
+    <Rule Id="CA5366" Action="None" />
+    <Rule Id="CA5368" Action="None" />
+    <Rule Id="CA5369" Action="None" />
+    <Rule Id="CA5370" Action="None" />
+    <Rule Id="CA5371" Action="None" />
+    <Rule Id="CA5372" Action="None" />
+    <Rule Id="CA5373" Action="None" />
+    <Rule Id="CA5374" Action="None" />
+    <Rule Id="CA5376" Action="None" />
+    <Rule Id="CA5377" Action="None" />
+    <Rule Id="CA5379" Action="None" />
+    <Rule Id="CA5380" Action="Info" />
+    <Rule Id="CA5381" Action="Info" />
+    <Rule Id="CA5384" Action="None" />
+    <Rule Id="CA5385" Action="None" />
+    <Rule Id="CA5386" Action="Info" />
+    <Rule Id="CA5391" Action="Info" />
+    <Rule Id="CA5395" Action="Info" />
+    <Rule Id="CA5396" Action="Info" />
+    <Rule Id="CA5398" Action="Info" />
+  </Rules>
+  <Rules AnalyzerId="Microsoft.NetCore.CSharp.Analyzers" RuleNamespace="Microsoft.NetCore.CSharp.Analyzers">
+    <Rule Id="CA1810" Action="None" />
+    <Rule Id="CA1824" Action="None" />
+    <Rule Id="CA1825" Action="None" />
+    <Rule Id="CA1829" Action="None" />
+    <Rule Id="CA2010" Action="None" />
+    <Rule Id="CA2207" Action="None" />
+  </Rules>
+  <Rules AnalyzerId="Microsoft.NetCore.VisualBasic.Analyzers" RuleNamespace="Microsoft.NetCore.VisualBasic.Analyzers">
+    <Rule Id="CA1309" Action="None" />
+    <Rule Id="CA1810" Action="None" />
+    <Rule Id="CA1824" Action="None" />
+    <Rule Id="CA1825" Action="None" />
+    <Rule Id="CA1829" Action="None" />
+    <Rule Id="CA2010" Action="None" />
+    <Rule Id="CA2207" Action="None" />
+  </Rules>
+  <Rules AnalyzerId="Microsoft.NetFramework.Analyzers" RuleNamespace="Microsoft.NetFramework.Analyzers">
+    <Rule Id="CA1058" Action="None" />
+  </Rules>
+  <Rules AnalyzerId="Microsoft.NetFramework.VisualBasic.Analyzers" RuleNamespace="Microsoft.NetFramework.VisualBasic.Analyzers">
+    <Rule Id="CA3076" Action="Warning" />
+    <Rule Id="CA3077" Action="Warning" />
+  </Rules>
+</RuleSet>
diff --git a/Build/Test.Psi.ruleset b/Build/Test.Psi.ruleset
@@ -1,18 +1,15 @@
 <?xml version="1.0" encoding="utf-8"?>
-<RuleSet Name="Microsoft Psi Test Project Rules" Description="These rules are used for Psi test projects." ToolsVersion="16.0">
-  <Localization ResourceAssembly="Microsoft.VisualStudio.CodeAnalysis.RuleSets.Strings.dll" ResourceBaseName="Microsoft.VisualStudio.CodeAnalysis.RuleSets.Strings.Localized">
-    <Name Resource="MinimumRecommendedRules_Name" />
-    <Description Resource="MinimumRecommendedRules_Description" />
-  </Localization>
+<RuleSet Name="Microsoft Psi Test Project Rules" Description="These rules are used for Psi test projects." ToolsVersion="15.0">
+  <Include Path="Security.ruleset" Action="Default" />
   <Rules AnalyzerId="Microsoft.Analyzers.ManagedCodeAnalysis" RuleNamespace="Microsoft.Rules.Managed">
-    <Rule Id="CA1001" Action="Warning" />
+    <Rule Id="CA1001" Action="None" />
     <Rule Id="CA1009" Action="Warning" />
     <Rule Id="CA1016" Action="Warning" />
     <Rule Id="CA1033" Action="Warning" />
     <Rule Id="CA1049" Action="Warning" />
     <Rule Id="CA1060" Action="Warning" />
     <Rule Id="CA1061" Action="Warning" />
-    <Rule Id="CA1063" Action="Warning" />
+    <Rule Id="CA1063" Action="None" />
     <Rule Id="CA1065" Action="Warning" />
     <Rule Id="CA1301" Action="Warning" />
     <Rule Id="CA1400" Action="Warning" />
@@ -70,15 +67,22 @@
   </Rules>
   <Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
     <Rule Id="SA0001" Action="None" />
+    <Rule Id="SA1005" Action="None" />
     <Rule Id="SA1008" Action="None" />
     <Rule Id="SA1009" Action="None" />
+    <Rule Id="SA1025" Action="None" />
+    <Rule Id="SA1108" Action="None" />
+    <Rule Id="SA1118" Action="None" />
     <Rule Id="SA1124" Action="None" />
-    <Rule Id="SA1305" Action="Warning" />
+    <Rule Id="SA1201" Action="None" />
+    <Rule Id="SA1202" Action="None" />
     <Rule Id="SA1401" Action="None" />
     <Rule Id="SA1402" Action="None" />
     <Rule Id="SA1407" Action="None" />
     <Rule Id="SA1504" Action="None" />
+    <Rule Id="SA1512" Action="None" />
     <Rule Id="SA1600" Action="None" />
+    <Rule Id="SA1602" Action="None" />
     <Rule Id="SA1652" Action="None" />
   </Rules>
 </RuleSet>
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -1,6 +1,6 @@
 # Contributing to Platform for Situated Intelligence
 
-We welcome contributions from the community in a variety of forms: from simply using it and filing issues and bugs, to writing and releasing your own new components, to creating pull requests for bug fixes or new features, etc. This document describes some of the things you need to know if you are going to contribute to the Platform for Situated Intelligence ecosystem. Please read it carefully before making source code changes.
+We welcome contributions from the community in a variety of forms: from simply using it and filing issues and bugs, to writing and releasing your own new components, to creating pull requests for bug fixes or new features, etc. This document describes some of the things you need to know if you are going to contribute to the Platform for Situated Intelligence ecosystem.
 
 ## Code of conduct
 
@@ -60,12 +60,14 @@ Below is a description of the directory structure for the Platform for Situated
 | Sources   | Audio         | Contains class libraries for audio components. |
 | Sources   | Calibration   | Contains class libraries for calibrating cameras. |
 | Sources   | Common        | Contains class libraries for common test support. |
-| Sources   | Extensions    | Contains class libraries that extend the \psi runtime class libraries. |
+| Sources   | Data          | Contains class libraries for creating and manipulating datasets. |
+| Sources   | Devices       | Contains class libraries that support enumerating devices. |
 | Sources   | Imaging       | Contains class libraries for \psi imaging, e.g. images, video capture, etc. |
 | Sources   | Integrations  | Contains integrations - libraries that provide shims around 3rd party libraries. |
-| Sources   | Kinect        | Contains class libraries for Kinect sensor components. |
+| Sources   | Kinect        | Contains class libraries for Azure Kinect and Kinect V2 sensor components. |
 | Sources   | Language      | Contains class libraries for natural language processing components. |
 | Sources   | Media         | Contains class libraries for media components. |
+| Sources   | RealSense     | Contains class libraries for RealSense sensor component. |
 | Sources   | Runtime       | Contains class libraries for \psi runtime. |
 | Sources   | Speech        | Contains class libraries for speech components. |
 | Sources   | Toolkits      | Contains toolkits - e.g. Finite State Machine toolkit, etc. |
@@ -74,20 +76,17 @@ Below is a description of the directory structure for the Platform for Situated
 
 ### Coding Style
 
-Platform for Situated Intelligence is an organically grown codebase. The consistency of style reflects this.
-For the most part, the team follows these [coding conventions](https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/inside-a-program/coding-conventions) along with these [design guidelines](https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/). Pull requests that reformat the code will not be accepted.
+For the most part, the Platform for Situated Intelligence codebase follows these [coding conventions](https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/inside-a-program/coding-conventions) along with these [design guidelines](https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/). 
 
-In case you would like to add a new project to the `Psi.sln` we require that the project is setup in a similar ways to the other projects to ensure a certain coding standard.
+In case you would like to add a new project to the `Psi.sln` we require that the project is setup in a similar ways to the other projects to ensure consistency.
 
 ### Build and Test
 
 To fully validate your changes, do a complete rebuild and test for both Debug and Release Configurations.
 
 ### Pull Requests
 
-We accept __bug fix pull requests__. Please make sure there is a corresponding tracking issue for the bug. When you submit a PR for a bug, please link to the issue.
-
-We also accept __new feature pull requests__. We are available to discuss new features. We recommend you open an issue if you plan to develop new features.
+We accept __bug fix pull requests__ as well as __new feature pull requests__. For bug fixes, please open a corresponding issue for the bug and link to it, if one does not already exist. We also recommend you open an issue if you plan to develop new features, which will help facilitate community discussions about the design, implementation, etc.
 
 Pull requests should:
 

diff --git a/Directory.Build.props b/Directory.Build.props
@@ -6,7 +6,7 @@
     <Company>Microsoft Corporation</Company>
     <Owners>microsoft,psi</Owners>
     <Authors>Microsoft</Authors>
-    <AssemblyVersion>0.11.82.2</AssemblyVersion>
+    <AssemblyVersion>0.12.53.2</AssemblyVersion>
     <FileVersion>$(AssemblyVersion)</FileVersion>
     <Version>$(AssemblyVersion)-beta</Version>
     <SignAssembly>false</SignAssembly>
@@ -21,6 +21,7 @@
     <!-- Workaround for arbitrary value in AssemblyInformationalVersionAttribute until it is fixed in VS 16 https://github.com/Microsoft/visualfsharp/issues/4822 -->
     <NoWarn>FS2003</NoWarn>
     <LangVersion>latest</LangVersion>
+    <RunCodeAnalysis>false</RunCodeAnalysis>
   </PropertyGroup>
 
   <!-- Support for building in Visual Studio versions 15.9 and up -->