[Fix] Add checks to ensure PLCrashReportExceptionInfo has non-nil name and reason #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForeverQ
force-pushed
the
non-nil-exception-reason
branch
from
214eca3
to
dceacaa
Compare
|
Hello and thank you for contribution! I researched this trying to find out why stringWithUTF8String may return nil in cases when the argument is not NULL (as we already have such checks), and came across this thread, which indicates that it may happen indeed if the argument data is not formatted correctly. Do you think it is the case? Understanding actual cases where you've encountered this issue would be helpful for us. |
|
Closing. Please reopen if you are still interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We encountered a system exception crash here on Outlook iOS when copying
PLCrashReport.exceptionInfo.exceptionReasonbut it was nil.By going through the code, this can only happen when
[NSString stringWithUTF8String:]returns nil here. Since thenameandreasonare desgined to be non-nil, this PR fixes this edge case by verifying them to be non-nil as expected.