devops(conda): publish a single version per OS instead of each supported Python version #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted Python version
yury-s
approved these changes
Apr 3, 2024
| binary_relocation: False | ||
| missing_dso_whitelist: "*" | ||
| entry_points: | ||
| - playwright = playwright.__main__:main | ||
|
|
||
| requirements: | ||
| build: | ||
| - python # [build_platform != target_platform] | ||
| - python >=3.8 # [build_platform != target_platform] |
There was a problem hiding this comment.
Do we have a test bot with such minimal version to ensure that we are still compatible with it? What I see below is just a python with the same version as was used for the build.
There was a problem hiding this comment.
We don't have such bots in place for conda, will do some manual testing, but this replicates what we do for pytest-playwright, so fairly confident that it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Currently we publish OS multiplied by supported Python version (see here), which is not necessary, this will reduce the published packages to only the supported OS'es which have a certain Python version requirement, like we have for Pypi.
Fixes #1023