Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read stream for downloads #2318

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Read stream for downloads #2318

wants to merge 2 commits into from

Conversation

BdEgh
Copy link

@BdEgh BdEgh commented Feb 26, 2024

All languages except Python seem to have such a thing.
Why not support this feature here as well?

@BdEgh BdEgh marked this pull request as ready for review February 26, 2024 08:07
@BdEgh
Copy link
Author

BdEgh commented Feb 26, 2024

@microsoft-github-policy-service agree

@BdEgh BdEgh marked this pull request as draft February 27, 2024 06:13
@BdEgh BdEgh marked this pull request as ready for review March 17, 2024 17:29
@BdEgh
Copy link
Author

BdEgh commented Mar 17, 2024

Just fixed mypy errors, nothing more
Should be ok now

@BdEgh
Copy link
Author

BdEgh commented Mar 29, 2024

I can't really find what linter wants to be documented :(

A comment here isn't enough?
https://github.com/microsoft/playwright-python/pull/2318/files#diff-d6f13195208ce0c069a6fab675c2cbfb71019d9eefc0a5c2a64bfb596b690238R6966-R6969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant