Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make TimeoutError extend builtins.TimeoutError #2297

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

danphenderson
Copy link
Contributor

Addressing issue #1495.

Note, depending on the Python implementation __builtins__ references either the module builtins or the dictionary builtins.__dict__. (Ref). Therefore, I am importing TimeoutError as TimeOutErrorBuiltin from builtins to account for this implementation detail.

Additionally, I modified .gitignore to ignore Pipenv artifacts.

@danphenderson danphenderson changed the title feat: make TimeoutError extends builtins.TimeoutError feat: make TimeoutError extend builtins.TimeoutError Feb 13, 2024
@danphenderson
Copy link
Contributor Author

@danphenderson please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@mxschmitt
Copy link
Member

Thank you for your contribution, lets add a test for it?

e.g. a small one after here.

@danphenderson
Copy link
Contributor Author

Good idea! Thank you for the feedback.

@mxschmitt mxschmitt merged commit 8cd06e5 into microsoft:main Feb 14, 2024
36 of 38 checks passed
mxschmitt added a commit that referenced this pull request Feb 20, 2024
mxschmitt added a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants