fix(connect): Future exception was never retrieved on close() (#2427)

microsoft · May 2, 2024 · cb94c25 · cb94c25
1 parent 5b64618
commit cb94c25
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/playwright/_impl/_connection.py b/playwright/_impl/_connection.py
@@ -293,6 +293,9 @@ def cleanup(self, cause: Exception = None) -> None:
         for ws_connection in self._child_ws_connections:
             ws_connection._transport.dispose()
         for callback in self._callbacks.values():
+            # To prevent 'Future exception was never retrieved' we ignore all callbacks that are no_reply.
+            if callback.no_reply:
+                continue
             callback.future.set_exception(self._closed_error)
         self._callbacks.clear()
         self.emit("close")