Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdpSession): events without payload #2913

Merged
merged 2 commits into from Apr 17, 2024
Merged

fix(cdpSession): events without payload #2913

merged 2 commits into from Apr 17, 2024

Conversation

mxschmitt
Copy link
Member

yury-s
yury-s approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it throwing before? Maybe add a test then?

@mxschmitt mxschmitt merged commit 57d81d4 into main Apr 17, 2024
10 of 15 checks passed
@mxschmitt mxschmitt deleted the bugfix/cdp-session-heartbeta branch April 17, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@campersau campersau campersau left review comments

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Custom/Unknown CDP events cause playwright to close
3 participants
@mxschmitt @campersau @yury-s