Skip to content

Commit

Permalink
Merge pull request #599 from mousetraps/i598
Browse files Browse the repository at this point in the history
#598 remove docker publish hooks
  • Loading branch information
mousetraps committed Nov 18, 2015
2 parents 0643875 + e1abd72 commit e1bf02c
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 41 deletions.
12 changes: 4 additions & 8 deletions Nodejs/Product/Nodejs/Nodejs.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -901,10 +901,6 @@
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<IncludeInVSIX>true</IncludeInVSIX>
</Content>
<ZipItem Include="Templates\Files\DockerfileTemplate\Dockerfile" />
<VSIXSourceItem Include="Templates\Files\DockerfileTemplate\Dockerfile">
<VSIXSubPath>FileTemplates\ReferenceFiles\Dockerfile</VSIXSubPath>
</VSIXSourceItem>
<None Include="Theme\contrast.vstheme">
<SubType>Designer</SubType>
</None>
Expand Down Expand Up @@ -1305,9 +1301,6 @@
<SubType>Designer</SubType>
</ZipItem>
<ZipItem Include="Templates\Files\UnitTest\UnitTest.js" />
<ZipItem Include="Templates\Files\DockerfileTemplate\Dockerfile.vstemplate">
<SubType>Designer</SubType>
</ZipItem>
<Content Include="TestFrameworks\find_tests.js">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<IncludeInVSIX>true</IncludeInVSIX>
Expand All @@ -1331,6 +1324,10 @@
<ZipItem Include="Templates\Files\TypeScriptUnitTest\UnitTest.vstemplate">
<SubType>Designer</SubType>
</ZipItem>
<ZipItem Include="Templates\Files\DockerfileTemplate\Dockerfile" />
<ZipItem Include="Templates\Files\DockerfileTemplate\Dockerfile.vstemplate">
<SubType>Designer</SubType>
</ZipItem>
<None Include="Theme\Microsoft.NodejsTools.theme.v11.0.pkgdef" />
<None Include="Theme\Microsoft.NodejsTools.theme.v12.0.pkgdef" />
<None Include="Theme\Microsoft.NodejsTools.theme.v14.0.pkgdef" />
Expand Down Expand Up @@ -1756,7 +1753,6 @@
</Target>
<PropertyGroup>
<PostBuildEvent>
echo f | xcopy /y $(ProjectDir)Templates\Files\DockerfileTemplate\Dockerfile $(OutDir)FileTemplates\ReferenceFiles\Dockerfile
copy /y $(OutDir)..\WebRole\Microsoft.NodejsTools.WebRole.dll $(OutDir)Debugger\RemoteDebug\
</PostBuildEvent>
</PropertyGroup>
Expand Down
19 changes: 0 additions & 19 deletions Nodejs/Product/Nodejs/Project/NodejsProjectNode.cs
Original file line number Diff line number Diff line change
Expand Up @@ -379,25 +379,6 @@ public NodejsProjectNode(NodejsProjectPackage package)
return new NodejsProjectNodeProperties(this);
}

public override int GetPropertyValue(string propertyName, string configName, uint storage, out string propertyValue) {
propertyValue = null;
switch (propertyName) {
case "DockerLinuxDockerfileContents":
propertyValue = DockerfileWizardExtension.GetDockerfileWithReplacements(
File.ReadAllText(@"FileTemplates\ReferenceFiles\Dockerfile"),
DTE
);
return VSConstants.S_OK;
case "DockerAppType":
propertyValue = "Node.js";
return VSConstants.S_OK;
case "DockerDefaultPublishContainerPort":
propertyValue = "8080";
return VSConstants.S_OK;
}
return base.GetPropertyValue(propertyName, configName, storage, out propertyValue);
}

protected override Stream ProjectIconsImageStripStream {
get {
return typeof(ProjectNode).Assembly.GetManifestResourceStream("Microsoft.VisualStudioTools.Resources.Icons.SharedProjectImageList.bmp");
Expand Down
9 changes: 0 additions & 9 deletions Nodejs/Product/ProjectWizard/DockerfileWizardExtension.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,9 @@

using System;
using System.Collections.Generic;
using System.Diagnostics;
using EnvDTE;
using Microsoft.VisualStudio.TemplateWizard;
using Microsoft.VisualStudioTools;
using System.IO;
using System.Windows.Forms;
using System.Text.RegularExpressions;

namespace Microsoft.NodejsTools.ProjectWizard {
/// <summary>
Expand Down Expand Up @@ -51,11 +47,6 @@ public sealed class DockerfileWizardExtension : IWizard {
replacementsDictionary.Add("$nodearguments$", arguments);
}

public static string GetDockerfileWithReplacements(string dockerFileContents, DTE dte) {
string arguments = GetFullNodeArguments(dte);
return dockerFileContents.Replace("$nodearguments$", arguments);
}

private static string GetFullNodeArguments(object automationObject) {
string arguments = null;
if (automationObject is DTE) {
Expand Down
1 change: 0 additions & 1 deletion Nodejs/Setup/NodejsTools/NodejsTools.wxs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
<DirectoryRef Id="Dir_$(var.key)InstallLocation">
<Directory Id="Dir_$(var.key)InstallLocationFileTemplates" Name="FileTemplates">
<Directory Id="Dir_$(var.key)FileTemplatesNewItem" Name="NewItem" />
<Directory Id="Dir_$(var.key)FileTemplatesReferenceFiles" Name="ReferenceFiles" />
</Directory>
<Directory Id="Dir_$(var.key)TestFrameworks" Name="TestFrameworks">
<Directory Id="Dir_$(var.key)TestFrameworksExportRunner" Name="ExportRunner" />
Expand Down
4 changes: 0 additions & 4 deletions Nodejs/Setup/NodejsTools/NodejsToolsFiles.proj
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@

<InstallDirectory>FileTemplatesNewItem</InstallDirectory>
</File>

<File Include="FileTemplates\ReferenceFiles\Dockerfile">
<InstallDirectory>FileTemplatesReferenceFiles</InstallDirectory>
</File>

<ItemTemplate Include="ItemTemplates\JavaScript\UnitTest.zip;
ItemTemplates\JavaScript\MochaUnitTest.zip;
Expand Down

0 comments on commit e1bf02c

Please sign in to comment.