Download artifacts in consistent way #525
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have created this as a draft because I think I will wait several next days before confirming everything works as expected. |
|
We have tested it during the last months and it works great. We haven't been experiencing any inconsistency since putting this into our container-based environments. I will switch from draft to the regular PR. You can decide if it's worth to implement into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARTIFACT CONSISTENCY PROBLEM:
We have realized that containers using shared folders to store artifacts were suffering from time to time from inconsistently downloaded artifacts.
When running on orchestrator, but basically whenever downloading artifacts from containers (and not from BcContainerHelper from the host machine) and using a shared folder, it's not possible to use mutext (which is the difference between in-container download vs. download on the host using BCCH) and guarantee only one process accessing the shared resources.
The provided functionality uses file lock that controls access and guarantees only one process can access and other containers will be waiting until done (with success or not).