Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce min data_disk_count to 4 in IO perf test. #3286

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SRIKKANTH
Copy link
Collaborator

@SRIKKANTH SRIKKANTH commented Apr 30, 2024

Having min data_disk_count =16 in these testcases is blocking tests on smaller sizes.

@SRIKKANTH SRIKKANTH marked this pull request as ready for review May 6, 2024 11:58
@LiliDeng
Copy link
Collaborator

LiliDeng commented May 6, 2024

@johnsongeorge-w please review, thanks.

Copy link
Collaborator

@johnsongeorge-w johnsongeorge-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the default for disk count and min iops as 16 and 5000 respectively in the default runbook.

@SRIKKANTH
Copy link
Collaborator Author

Set the default for disk count and min iops as 16 and 5000 respectively.
@johnsongeorge-w This is what the default in the test case which is blocking us the test from running on smaller tests.
I am reducing the min disc count to 4 which is the minimum number of discs supported any azure VM SKU.

@johnsongeorge-w
Copy link
Collaborator

Set the default for disk count and min iops as 16 and 5000 respectively.
@johnsongeorge-w This is what the default in the test case which is blocking us the test from running on smaller tests.
I am reducing the min disc count to 4 which is the minimum number of discs supported any azure VM SKU.

I'm talking about the defaults in runbook

@SRIKKANTH
Copy link
Collaborator Author

Set the default for disk count and min iops as 16 and 5000 respectively.
@johnsongeorge-w This is what the default in the test case which is blocking us the test from running on smaller tests.
I am reducing the min disc count to 4 which is the minimum number of discs supported any azure VM SKU.

I'm talking about the defaults in runbook
The default runbook ("runbook\partial\platform_azure.yml") has values data_disk_iops=0, data_disk_count=0.
Changing these values will result in creation of each test VM with that config.
I don't think its a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants