Add Image Feature Requirements #3255
Conversation
kamalca
force-pushed
the
kameroncarr/image-features
branch
8 times, most recently
from
b57517c
to
65dfcd5
Compare
kamalca
force-pushed
the
kameroncarr/image-features
branch
3 times, most recently
from
8627bf6
to
91c93f3
Compare
|
@LiliDeng Do you have a Community Gallery Image I can test my changes on? |
community_gallery_image: "southcentralus/FreeBSDCGTest-d8a43fa5-745a-4910-9f71-0c9da2ac22bf/FreeBSD-14.0-RC3-amd64-ufs-gen1-testing/latest" please specify the location southcentralus |
kamalca
force-pushed
the
kameroncarr/image-features
branch
from
91c93f3
to
8600acc
Compare
kamalca
force-pushed
the
kameroncarr/image-features
branch
from
8600acc
to
707e9af
Compare
kamalca
force-pushed
the
kameroncarr/image-features
branch
9 times, most recently
from
b081dce
to
d929fc8
Compare
kamalca
force-pushed
the
kameroncarr/image-features
branch
4 times, most recently
from
d929fc8
to
751e829
Compare
|
@LiliDeng LGTM |
|
@kamalca could you please run a test with gallery arm64 image? |
Shared Image Gallery or Community Gallery Image? |
You need cover all scenarios, I hit one issue when run a test with Shared Image Gallery. |
kamalca
force-pushed
the
kameroncarr/image-features
branch
from
751e829
to
00aa945
Compare
I fixed a typo. Thank you for helping test the changes. |
|
@LiliDeng Any updates on this getting merged? I have to do more work to continually rebase, merge conflicts, and retest changes the longer this goes unmerged. |
Tags from Azure Images are now parsed to determine features such as Architecture, Security Profile, and Disk Controller Type.
kamalca
force-pushed
the
kameroncarr/image-features
branch
from
00aa945
to
e806ace
Compare
Each feature can now implement a function
create_image_requirementto determine a requirement based on the raw_capabilities of the image. The requirement is then merged with the platform requirement.