Disabling ASA extension for AzSecPack #3220
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Mar 19, 2024
| @@ -123,7 +123,7 @@ def verify_azsecpack(self, node: Node, log: Logger, result: TestResult) -> None: | |||
| # Install agent extension | |||
| try: | |||
| self._install_monitor_agent_extension(node) | |||
| self._install_security_agent_extension(node, log) | |||
| # self._install_security_agent_extension(node, log) | |||
There was a problem hiding this comment.
- Please explain the reason to comment out it in the PR.
- Remove the line directly, instead of commenting out.
There was a problem hiding this comment.
This is to test a specific custom image. In order to run a pipeline I had to raise this PR and then use its GitHub reference in the pipeline. This is the reason I marked the PR as draft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling ASA extension for AzSecPack