Changed the timeout number #3158
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Jan 29, 2024
lisa/schema.py
Outdated
| @@ -1577,7 +1577,7 @@ class Runbook: | |||
| tags: Optional[List[str]] = None | |||
| concurrency: int = 1 | |||
| # minutes to wait for resource | |||
| wait_resource_timeout: float = 5 | |||
| wait_resource_timeout: float = 10 | |||
There was a problem hiding this comment.
You can configure it in runbook. And don't mention internal work in GitHub.
paulli2017
force-pushed
the
paull/kvtest
branch
16 times, most recently
from
50cd948
to
5c02d25
Compare
squirrelsc
reviewed
Jan 30, 2024
| $sshd_config = "C:\ProgramData\ssh\sshd_config" | ||
| (Get-Content $sshd_config) -replace '#PubkeyAuthentication', 'PubkeyAuthentication' | Out-File -encoding ASCII $sshd_config | ||
| $ssh_server = Get-Service sshd | Where-Object { $_.Name -like 'sshd' -and $_.Status -like "Running" } | ||
| if ($ssh_server) |
There was a problem hiding this comment.
What does it mean, if ssh_server is not here? It may cause key auth changes are skipped.
squirrelsc
reviewed
Jan 30, 2024
| @@ -149,7 +149,7 @@ def command(self) -> str: | |||
| def _check_exists(self) -> bool: | |||
| return True | |||
|
|
|||
| def reboot(self, time_out: int = 600) -> None: | |||
| def reboot(self, time_out: int = 1200) -> None: | |||
There was a problem hiding this comment.
It doesn't need to change the default value. Specify the value when it's called.
squirrelsc
reviewed
Jan 30, 2024
lisa/tools/reboot.py
Outdated
| @@ -174,7 +174,7 @@ def reboot(self, time_out: int = 600) -> None: | |||
| constants.ENVIRONMENTS_NODES_REMOTE_PORT | |||
| ], | |||
| log=self._log, | |||
| timeout=20, | |||
| timeout=1200, | |||
There was a problem hiding this comment.
20 should be enough, in this loop it will try multiple times.
paulli2017
force-pushed
the
paull/kvtest
branch
10 times, most recently
from
76e03b7
to
a582a9f
Compare
paulli2017
force-pushed
the
paull/kvtest
branch
5 times, most recently
from
3a495d8
to
dd51ded
Compare
paulli2017
force-pushed
the
paull/kvtest
branch
2 times, most recently
from
e1c8f60
to
6c70a2a
Compare
paulli2017
force-pushed
the
paull/kvtest
branch
from
6c70a2a
to
57b8abb
Compare
|
@paulli2017 hi, are you planning to update this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test for kernel validation pipeline test