Onboarding MDE for Linux to LISA #3113
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshan1995
commented
Dec 21, 2023
| @@ -0,0 +1,58 @@ | |||
| name: azure default | |||
There was a problem hiding this comment.
This is just for testing purpose. Will remove it once incorporate all the review comments
subhajitm
reviewed
Dec 21, 2023
subhajitm
reviewed
Dec 21, 2023
squirrelsc
reviewed
Dec 22, 2023
| from .remote_copy import RemoteCopy | ||
| from .whoami import Whoami | ||
|
|
||
| class MDE(Tool): |
There was a problem hiding this comment.
It's used by MDE test suite only, so it can be in the same file with the test suite.
LiliDeng
reviewed
Dec 22, 2023
|
|
||
| node.tools[Curl].fetch(arg="-o /tmp/eicar.com.txt", | ||
| execute_arg="", | ||
| url="https://secure.eicar.org/eicar.com.txt") |
There was a problem hiding this comment.
I hope it won't trigger any security alert?
LiliDeng
reviewed
Dec 22, 2023
LiliDeng
reviewed
Dec 22, 2023
LiliDeng
reviewed
Dec 22, 2023
LiliDeng
reviewed
Dec 22, 2023
LiliDeng
reviewed
Dec 22, 2023
LiliDeng
reviewed
Dec 22, 2023
LiliDeng
reviewed
Dec 22, 2023
| log.error(e) | ||
| output = False | ||
|
|
||
| assert_that(output).described_as('Unable to install MDE').is_equal_to(True) |
There was a problem hiding this comment.
Is the description (described_as) supposed to be opposite of what is being checked (is_equal_to) here and elsewhere?
|
@zeeshan1995 any plan for this PR? |
@LiliDeng Yes, we plan to merge the PR. We are having some discussion on this. Will get back to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Onboard Microsoft Defender for Endpoint(MDE) for Linux with basic tests.