MANA: add driver survey test #2980
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Sep 26, 2023
squirrelsc
reviewed
Sep 26, 2023
mana_en drivers should be present in kernels >= 5.15. mana_ib drivers should be present in kernels >= 6.2. Add a test to survey images and check for mana drivers in images.
mcgov
force-pushed
the
mcgov/mana-drjver
branch
from
d86f226
to
1778d01
Compare
LiliDeng
reviewed
Sep 27, 2023
microsoft/testsuites/core/mana.py
Outdated
| kconfig = node.tools[KernelConfig] | ||
|
|
||
| # Check kconfig for mana | ||
| mana_is_builtin = kconfig.is_built_in(mana_driver_name) |
There was a problem hiding this comment.
we can add a new method for the common code used by these two cases
LiliDeng
reviewed
Sep 27, 2023
| ) | ||
| class ManaDriverCheck(TestSuite): | ||
| MANA_DRIVER_MESSAGE_PATTERN = re.compile(r"\[\s*[0-9.]+\s*\]\s+mana\s+.*") | ||
| MANA_IB_DRIVER_MESSAGE_PATTERN = re.compile(r"\[\s*[0-9.]+\s*\]\s+mana_ib\s+.*") |
There was a problem hiding this comment.
I don't see the updated with sample messages
LiliDeng
reviewed
Sep 27, 2023
| mana_driver_name = "mana" | ||
| dmesg = node.tools[Dmesg] | ||
| modprobe = node.tools[Modprobe] | ||
| kconfig = node.tools[KernelConfig] |
There was a problem hiding this comment.
we can check config even there is no mana devices
There was a problem hiding this comment.
added a test just kconfig only
|
block merge on testing after refactor... |
mcgov
force-pushed
the
mcgov/mana-drjver
branch
from
645a53f
to
e4866c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mana_en drivers should be present in kernels >= 5.15.
mana_ib drivers should be present in kernels >= 6.2.
Add a test to survey images and check for mana drivers in images.
Test checks kernel config and modprobe to verify the driver is present as either a builtin or module. It checks kernel logs to verify the driver had loaded as expected.