Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Fix page titles and add microsoft favicon #112

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fix page titles and add microsoft favicon #112

wants to merge 9 commits into from

Conversation

elrmndo
Copy link
Contributor

@elrmndo elrmndo commented Mar 10, 2019

Added titles to the pages and somewhat added a favicon w/c is the microsoft logo from microsoft.com

@micahgodbolt
Copy link
Member

not familiar with that favicon URL. Can you try to find an official version?

Copy link
Member

@micahgodbolt micahgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update favicon

@micahgodbolt
Copy link
Member

Also, it looks like you checked in a TON of changes that are simply whitespace updates. Can you only submit actual code changes. git add -p helps

@ahtee
Copy link

ahtee commented Mar 11, 2019

wouldn't hurt to import an svg or official icon into the assets dir

@elrmndo
Copy link
Contributor Author

elrmndo commented Mar 12, 2019

i actually got the favicon from the microsoft website anws, i'll be changing it and add an svg in the assets folder, also i might be reverting it back and redo the changes

i wasn't really also sure what caused the reformatting, i would also try to check on that

@elrmndo
Copy link
Contributor Author

elrmndo commented Mar 12, 2019

actually found out that series of white spaces/auto format occurred w/o me having prettier extension installed in vscode so when I save, it auto formats with a bunch of spaces 😟

@ahtee
Copy link

ahtee commented Mar 12, 2019

actually found out that series of white spaces/auto format occurred w/o me having prettier extension installed in vscode so when I save, it auto formats with a bunch of spaces 😟

can you turn off prettier in vscode and try to revert those changes?

@elrmndo
Copy link
Contributor Author

elrmndo commented Mar 13, 2019

actually found out that series of white spaces/auto format occurred w/o me having prettier extension installed in vscode so when I save, it auto formats with a bunch of spaces 😟

can you turn off prettier in vscode and try to revert those changes?

I actually did the other way around and committed a better version of it at 6aa2825

Copy link
Contributor Author

@elrmndo elrmndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the favicon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants