Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to react-icons 2.0.239 #31287

Merged
merged 9 commits into from May 13, 2024
Merged

chore: migrate to react-icons 2.0.239 #31287

merged 9 commits into from May 13, 2024

Conversation

tomi-msft
Copy link
Contributor

@tomi-msft tomi-msft commented May 6, 2024 •
edited by Hotell

Update react-icons version to 2.0.239, which contains fix to the providers export path that was incorrectly exporting the commonjs module from a nonexistent file.

Related issues:

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone May 6, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented May 6, 2024 •
edited

📊 Bundle size report

✅ No changes found

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 6, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented May 6, 2024 •
edited

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender-with-unmount 70 75 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 598 592 5000
Button mount 288 284 5000
Field mount 1134 1126 5000
FluentProvider mount 702 693 5000
FluentProviderWithTheme mount 73 76 10
FluentProviderWithTheme virtual-rerender 33 35 10
FluentProviderWithTheme virtual-rerender-with-unmount 70 75 10 Possible regression
MakeStyles mount 837 840 50000
Persona mount 1665 1640 5000
SpinButton mount 1314 1321 5000
SwatchPicker mount 1465 1444 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 6, 2024 •
edited

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 6, 2024 •
edited

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonMinimalPerf.default 81 87 0.93:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 88 78 1.13:1
ChatDuplicateMessagesPerf.default 164 151 1.09:1
ImageMinimalPerf.default 243 223 1.09:1
MenuMinimalPerf.default 530 486 1.09:1
FlexMinimalPerf.default 168 157 1.07:1
TreeWith60ListItems.default 97 91 1.07:1
ChatWithPopoverPerf.default 205 194 1.06:1
BoxMinimalPerf.default 196 187 1.05:1
LoaderMinimalPerf.default 201 191 1.05:1
SplitButtonMinimalPerf.default 2334 2219 1.05:1
CarouselMinimalPerf.default 265 255 1.04:1
ChatMinimalPerf.default 446 428 1.04:1
InputMinimalPerf.default 551 528 1.04:1
LayoutMinimalPerf.default 203 196 1.04:1
ListWith60ListItems.default 398 382 1.04:1
ProviderMinimalPerf.default 206 198 1.04:1
RadioGroupMinimalPerf.default 278 267 1.04:1
ToolbarMinimalPerf.default 562 538 1.04:1
AttachmentSlotsPerf.default 647 631 1.03:1
AvatarMinimalPerf.default 106 103 1.03:1
ButtonOverridesMissPerf.default 690 669 1.03:1
CardMinimalPerf.default 310 301 1.03:1
DialogMinimalPerf.default 456 443 1.03:1
LabelMinimalPerf.default 221 214 1.03:1
SliderMinimalPerf.default 774 753 1.03:1
TableManyItemsPerf.default 1125 1097 1.03:1
ListMinimalPerf.default 315 309 1.02:1
MenuButtonMinimalPerf.default 978 955 1.02:1
PopupMinimalPerf.default 353 345 1.02:1
ReactionMinimalPerf.default 215 211 1.02:1
RefMinimalPerf.default 112 110 1.02:1
SkeletonMinimalPerf.default 200 197 1.02:1
TableMinimalPerf.default 237 233 1.02:1
DatepickerMinimalPerf.default 3899 3853 1.01:1
DropdownMinimalPerf.default 1432 1419 1.01:1
EmbedMinimalPerf.default 1908 1892 1.01:1
FormMinimalPerf.default 221 219 1.01:1
HeaderMinimalPerf.default 209 207 1.01:1
ItemLayoutMinimalPerf.default 710 702 1.01:1
TextAreaMinimalPerf.default 288 286 1.01:1
CustomToolbarPrototype.default 1552 1537 1.01:1
ListNestedPerf.default 331 332 1:1
RosterPerf.default 1559 1556 1:1
ProviderMergeThemesPerf.default 651 653 1:1
StatusMinimalPerf.default 395 395 1:1
AnimationMinimalPerf.default 297 300 0.99:1
CheckboxMinimalPerf.default 1142 1154 0.99:1
PortalMinimalPerf.default 83 84 0.99:1
GridMinimalPerf.default 187 191 0.98:1
SegmentMinimalPerf.default 193 196 0.98:1
AlertMinimalPerf.default 155 160 0.97:1
ButtonSlotsPerf.default 306 316 0.97:1
ListCommonPerf.default 385 398 0.97:1
TooltipMinimalPerf.default 1241 1278 0.97:1
TreeMinimalPerf.default 489 504 0.97:1
VideoMinimalPerf.default 407 419 0.97:1
HeaderSlotsPerf.default 460 480 0.96:1
TextMinimalPerf.default 189 197 0.96:1
DropdownManyItemsPerf.default 389 411 0.95:1
DividerMinimalPerf.default 195 210 0.93:1
IconMinimalPerf.default 361 387 0.93:1
AttachmentMinimalPerf.default 75 85 0.88:1

@fabricteam
Copy link
Collaborator

fabricteam commented May 6, 2024 •
edited

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 6, 2024 •
edited

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 629 635 5000
Breadcrumb mount 1723 1763 1000
Checkbox mount 1712 1697 5000
CheckboxBase mount 1501 1490 5000
ChoiceGroup mount 3059 2932 5000
ComboBox mount 673 683 1000
CommandBar mount 6869 6672 1000
ContextualMenu mount 14748 14744 1000
DefaultButton mount 799 816 5000
DetailsRow mount 2194 2176 5000
DetailsRowFast mount 2165 2238 5000
DetailsRowNoStyles mount 2039 2045 5000
Dialog mount 2801 2662 1000
DocumentCardTitle mount 240 233 1000
Dropdown mount 2008 2015 5000
FocusTrapZone mount 1148 1147 5000
FocusZone mount 1078 1081 5000
GroupedList mount 38169 42759 2
GroupedList virtual-rerender 18173 20411 2
GroupedList virtual-rerender-with-unmount 51567 51644 2
GroupedListV2 mount 232 234 2
GroupedListV2 virtual-rerender 217 219 2
GroupedListV2 virtual-rerender-with-unmount 246 235 2
IconButton mount 1107 1135 5000
Label mount 338 348 5000
Layer mount 2799 2784 5000
Link mount 400 403 5000
MenuButton mount 1031 1010 5000
MessageBar mount 21319 21545 5000
Nav mount 2052 2003 1000
OverflowSet mount 796 801 5000
Panel mount 1852 1807 1000
Persona mount 755 768 1000
Pivot mount 899 931 1000
PrimaryButton mount 915 924 5000
Rating mount 4557 4664 5000
SearchBox mount 932 927 5000
Shimmer mount 1922 1950 5000
Slider mount 1344 1325 5000
SpinButton mount 2986 3004 5000
Spinner mount 387 376 5000
SplitButton mount 1871 1834 5000
Stack mount 413 407 5000
StackWithIntrinsicChildren mount 879 855 5000
StackWithTextChildren mount 2667 2633 5000
SwatchColorPicker mount 6445 6407 5000
TagPicker mount 1487 1466 5000
Text mount 379 389 5000
TextField mount 968 948 5000
ThemeProvider mount 847 839 5000
ThemeProvider virtual-rerender 590 589 5000
ThemeProvider virtual-rerender-with-unmount 1312 1291 5000
Toggle mount 618 617 5000
buttonNative mount 197 191 5000

@fabricteam
Copy link
Collaborator

fabricteam commented May 6, 2024 •
edited

🕵 fluentuiv9 No visual regressions between this PR and main

@Hotell Hotell self-requested a review May 7, 2024 12:09
Hotell
Hotell reviewed May 7, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@Hotell Hotell changed the title React icons 239 update chore: migrate to react-icons 2.0.239 May 7, 2024
@Hotell
Copy link
Contributor

Hotell commented May 7, 2024

@tomi-msft I updated title and PR description.

While we don't have change-logs yet within icons repo, it would be great if you could provide more context by linking merged PRs in the future.

ty

@tomi-msft tomi-msft merged commit c35e78e into microsoft:master May 13, 2024
21 checks passed
@tomi-msft tomi-msft deleted the react-icons-239-update branch May 13, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hotell Hotell Hotell approved these changes

@layershifter layershifter layershifter approved these changes

@spmonahan spmonahan spmonahan approved these changes

@Mitch-At-Work Mitch-At-Work Mitch-At-Work approved these changes

@sopranopillow sopranopillow Awaiting requested review from sopranopillow sopranopillow is a code owner

@mltejera mltejera Awaiting requested review from mltejera mltejera is a code owner

@smhigley smhigley Awaiting requested review from smhigley smhigley is a code owner

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT GeoffCoxMSFT is a code owner

@khmakoto khmakoto Awaiting requested review from khmakoto khmakoto is a code owner

@ms-acalzaretto ms-acalzaretto Awaiting requested review from ms-acalzaretto ms-acalzaretto is a code owner

@behowell behowell Awaiting requested review from behowell behowell is a code owner

@micahgodbolt micahgodbolt Awaiting requested review from micahgodbolt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tomi-msft @fabricteam @Hotell @layershifter @spmonahan @Mitch-At-Work