fix: react ColorSlider hue gradient #31238
Open
+14
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
The background gradient used by the hue slider of ColorPicker does not accurately represent a gradient through hues with constant saturation/ lightness because it is implemented with 10 stops instead of the 6 primary/secondary stops needed to correctly represent the hue gradient with an RGB interpolation. In particular, the current gradient has incorrect lightness dips around fuchsia and yellow and (less noticeable) lightness bumps around lime and blue.
yoonbuck
commented
May 14, 2024
Comment on lines
+8
to
+14
| 'red', | ||
| 'fuchsia', | ||
| 'blue', | ||
| 'aqua', | ||
| 'lime', | ||
| 'yellow', | ||
| 'red', |
There was a problem hiding this comment.
I went with color names based on the existing code appearing to prefer names > short hex > long hex literals.
I also excluded the percentages because they aren't required (stops are spaced evenly if omitted) and more difficult to write clearly since stops are 1/6 instead of 1/10.
I can change either of these (names → short or long hex literals; add percentages) if it would be preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background gradient used by the hue slider of ColorPicker does not accurately represent a gradient through hues with constant saturation/lightness because it is created with 10 stops instead of the 6 primary/secondary stops needed to correctly represent the hue gradient using RGB interpolation.
In particular, the current gradient has incorrect muddy lightness dips around fuchsia and yellow and (less noticeable) lightness bumps around lime and blue.
Upper: current hue gradient (10 stops)
Lower: correct hue gradient (6 stops)
Previous Behavior
New Behavior