Adds High Contrast Styles to Badge Web Component #31234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
procload
changed the title
📊 Bundle size report✅ No changes found |
fabricteam
reviewed
Apr 30, 2024
change/@fluentui-web-components-00702120-ccca-469e-aee3-d0a77b0b9d4c.json
Show resolved
Hide resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
radium-v
force-pushed
the
web-components-v3
branch
from
3287714
to
3d89250
Compare
procload
requested review from
a team,
GeoffCoxMSFT,
marcosmoura,
sopranopillow,
tomi-msft,
micahgodbolt,
smhigley,
behowell,
spmonahan,
khmakoto,
dzearing,
Jacqueline-ms,
robtaft-ms,
Hirse,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
chrisdholt
approved these changes
May 14, 2024
Hotell
removed request for
a team,
dzearing,
marcosmoura,
micahgodbolt,
Hirse,
robtaft-ms,
smhigley,
sopranopillow,
khmakoto,
jurokapsiar,
GeoffCoxMSFT,
Jacqueline-ms,
JustSlone,
behowell,
tomi-msft,
spmonahan and
tudorpopams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on enhancing the visual accessibility of the badge web component in the
@fluentui/web-componentspackage by introducing high contrast styles. The changes are made in two files:change/@fluentui-web-components-00702120-ccca-469e-aee3-d0a77b0b9d4c.jsonandpackages/web-components/src/badge/badge.styles.ts.High contrast style enhancements:
change/@fluentui-web-components-00702120-ccca-469e-aee3-d0a77b0b9d4c.json: A new pre-release patch has been added which includes high contrast styles for the badge web component.packages/web-components/src/badge/badge.styles.ts: TheforcedColorsStylesheetBehaviorutility has been imported and applied to the badge styles. This utility applies high contrast styles when the system's high contrast mode is enabled. The border color of the badge in different appearances (default, outline, tint) is set toCanvasTextin high contrast mode. [1] [2]Previous Behavior
Without high-contrast styles:
New Behavior
With new high-contrast styles: