Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "feat: add .js file extension to built output + unwrap folder import/export to support native ESM within browser" #30803

Merged
merged 2 commits into from Mar 18, 2024
Merged

revert: "feat: add .js file extension to built output + unwrap folder import/export to support native ESM within browser" #30803

merged 2 commits into from Mar 18, 2024

Conversation

micahgodbolt
Copy link
Member

@micahgodbolt micahgodbolt commented Mar 18, 2024 •
edited

Reverts #30770

Issue this PR caused:

#30795
#30802

@micahgodbolt micahgodbolt requested a review from a team as a code owner March 18, 2024 17:20
@github-actions github-actions bot added this to the March Project Cycle Q1 2024 milestone Mar 18, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Mar 18, 2024 •
edited

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
328 B
global-context
createContextSelector		 537 B
339 B
keyboard-key
keyboard-key package		 3.746 kB
1.928 kB
priority-overflow
createOverflowManager		 4.447 kB
1.853 kB
react
ActivityItem		 68.833 kB
22.613 kB
react
Announced		 36.473 kB
12.628 kB
react
Autofill		 15.365 kB
4.743 kB
react
Breadcrumb		 196.083 kB
58.757 kB
react
Button		 190.127 kB
55.019 kB
react
ButtonGrid		 175.918 kB
53.25 kB
react
Calendar		 118.756 kB
36.101 kB
react
Callout		 80.866 kB
26.564 kB
react
Check		 51.062 kB
17.152 kB
react
Checkbox		 57.791 kB
19.17 kB
react
ChoiceGroup		 63.339 kB
20.824 kB
react
ChoiceGroupOption		 56.601 kB
18.695 kB
react
Coachmark		 89.704 kB
28.407 kB
react
Color		 7.737 kB
3.106 kB
react
ColorPicker		 129.984 kB
40.589 kB
react
ComboBox		 245.355 kB
70.51 kB
react
CommandBar		 197.362 kB
58.46 kB
react
ContextualMenu		 150.967 kB
46.982 kB
react
DatePicker		 180.318 kB
54.947 kB
react
DateTimeUtilities		 5.244 kB
1.849 kB
react
DetailsList		 225.886 kB
64.647 kB
react
Dialog		 205.294 kB
61.428 kB
react
Divider		 17.63 kB
6.234 kB
react
DocumentCard		 211.08 kB
62.793 kB
react
DragDrop		 8.343 kB
2.724 kB
react
DraggableZone		 33.345 kB
11.166 kB
react
Dropdown		 227.732 kB
66.867 kB
react
ExtendedPicker		 94.987 kB
27.297 kB
react
Fabric		 39.75 kB
13.688 kB
react
Facepile		 205.992 kB
61.67 kB
react
FloatingPicker		 236.233 kB
67.368 kB
react
FocusTrapZone		 15.831 kB
5.54 kB
react
FocusZone		 53.259 kB
16.869 kB
react
Grid		 175.918 kB
53.25 kB
react
GroupedList		 131.636 kB
39.657 kB
react
GroupedListV2		 119.324 kB
36.822 kB
react
HoverCard		 93.735 kB
29.778 kB
react
Icon		 49.74 kB
16.603 kB
react
Icons		 65.829 kB
24.212 kB
react
Image		 44.79 kB
15.024 kB
react
Keytip		 78.588 kB
25.825 kB
react
KeytipData		 13.585 kB
4.418 kB
react
KeytipLayer		 100.422 kB
31.128 kB
react
Keytips		 103.175 kB
32.07 kB
react
Label		 36.347 kB
12.639 kB
react
Layer		 45.683 kB
15.585 kB
react
Link		 37.673 kB
12.993 kB
react
List		 38.136 kB
12.004 kB
react
MarqueeSelection		 72.119 kB
21.676 kB
react
MessageBar		 184.707 kB
55.523 kB
react
Modal		 90.409 kB
29.213 kB
react
Nav		 183.442 kB
55.093 kB
react
OverflowSet		 31.044 kB
10.593 kB
react
Overlay		 38.784 kB
13.401 kB
react
Panel		 194.946 kB
58.34 kB
react
Persona		 111.705 kB
35.58 kB
react
PersonaCoin		 111.705 kB
35.58 kB
react
PersonaPresence		 55.928 kB
18.715 kB
react
Pickers		 287.603 kB
80.607 kB
react
Pivot		 184.252 kB
55.823 kB
react
Popup		 12.032 kB
4.114 kB
react
Positioning		 21.821 kB
7.334 kB
react
PositioningContainer		 70.754 kB
22.84 kB
react
ProgressIndicator		 37.498 kB
12.906 kB
react
Rating		 78.989 kB
25.18 kB
react
ResizeGroup		 13.286 kB
4.365 kB
react
ResponsiveMode		 8.078 kB
2.95 kB
react
ScrollablePane		 53.538 kB
17.113 kB
react
SearchBox		 182.982 kB
55.1 kB
react
SelectableOption		 724 B
413 B
react
SelectedItemsList		 226.659 kB
66.321 kB
react
Selection		 41.202 kB
11.839 kB
react
Separator		 33.397 kB
11.529 kB
react
Shimmer		 47.265 kB
15.632 kB
react
ShimmeredDetailsList		 236.654 kB
67.42 kB
react
Slider		 55.575 kB
18.574 kB
react
SpinButton		 186.661 kB
56.205 kB
react
Spinner		 39.691 kB
13.815 kB
react
Stack		 40.761 kB
13.931 kB
react
Sticky		 32.064 kB
10.324 kB
react
Styling		 44.812 kB
14.688 kB
react
SwatchColorPicker		 186.166 kB
56.724 kB
react
TeachingBubble		 200.004 kB
59.345 kB
react
Text		 35.931 kB
12.486 kB
react
TextField		 78.587 kB
24.642 kB
react
Theme		 42.456 kB
13.773 kB
react
ThemeGenerator		 12.34 kB
4.106 kB
react
TimePicker		 235.197 kB
68.29 kB
react
Toggle		 44.17 kB
15.346 kB
react
Tooltip		 84.225 kB
27.277 kB
react
Utilities		 71.851 kB
21.843 kB
react
Viewport		 22.945 kB
7.292 kB
react
WeeklyDayPicker		 98.762 kB
30.828 kB
react
WindowProvider		 1.059 kB
541 B
react-accordion
Accordion (including children components)		 100.125 kB
30.423 kB
react-alert
Alert		 83.737 kB
23.475 kB
react-avatar
Avatar		 50.175 kB
15.944 kB
react-avatar
AvatarGroup		 19.702 kB
7.794 kB
react-avatar
AvatarGroupItem		 64.829 kB
20.272 kB
react-badge
Badge		 26.905 kB
8.73 kB
react-badge
CounterBadge		 27.806 kB
9.025 kB
react-badge
PresenceBadge		 25.311 kB
9.307 kB
react-breadcrumb
@fluentui/react-breadcrumb - package		 115.48 kB
31.843 kB
react-button
Button		 39.513 kB
11.17 kB
react-button
CompoundButton		 46.874 kB
12.662 kB
react-button
MenuButton		 44.292 kB
12.544 kB
react-button
SplitButton		 52.306 kB
14.135 kB
react-button
ToggleButton		 56.558 kB
13.068 kB
react-calendar-compat
Calendar Compat		 152.073 kB
39.83 kB
react-card
Card - All		 101.557 kB
28.932 kB
react-card
Card		 96.382 kB
27.401 kB
react-card
CardFooter		 13.064 kB
5.386 kB
react-card
CardHeader		 15.307 kB
6.144 kB
react-card
CardPreview		 14.015 kB
5.752 kB
react-checkbox
Checkbox		 35.656 kB
12.07 kB
react-combobox
Combobox (including child components)		 102.686 kB
33.174 kB
react-combobox
Dropdown (including child components)		 104.06 kB
33.101 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 71.098 kB
20.515 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 217.205 kB
61.941 kB
react-components
react-components: FluentProvider & webLightTheme		 43.585 kB
14.352 kB
react-datepicker-compat
DatePicker Compat		 224.523 kB
62.94 kB
react-dialog
Dialog (including children components)		 100.928 kB
29.921 kB
react-divider
Divider		 20.922 kB
7.791 kB
react-field
Field		 22.542 kB
8.609 kB
react-image
Image		 15.745 kB
6.231 kB
react-infobutton
InfoButton		 138.694 kB
43.395 kB
react-infobutton
InfoLabel		 142.495 kB
44.625 kB
react-input
Input		 26.891 kB
9.12 kB
react-jsx-runtime
Classic Pragma		 1.057 kB
530 B
react-jsx-runtime
JSX Dev Runtime		 3.781 kB
1.646 kB
react-jsx-runtime
JSX Runtime		 4.377 kB
1.881 kB
react-label
Label		 14.266 kB
5.829 kB
react-link
Link		 17.082 kB
6.911 kB
react-menu
Menu (including children components)		 149.426 kB
45.505 kB
react-menu
Menu (including selectable components)		 152.112 kB
46.018 kB
react-message-bar
MessageBar (all components)		 25.566 kB
9.13 kB
react-northstar
Accordion		 85.392 kB
26.518 kB
react-northstar
Alert		 87.45 kB
26.902 kB
react-northstar
Animation		 55.34 kB
17.829 kB
react-northstar
Attachment		 86.844 kB
26.692 kB
react-northstar
Avatar		 80.279 kB
24.629 kB
react-northstar
Box		 75.248 kB
23.806 kB
react-northstar
Breadcrumb		 79.92 kB
24.709 kB
react-northstar
Button		 83.16 kB
25.947 kB
react-northstar
Card		 82.705 kB
25.023 kB
react-northstar
Carousel		 105.182 kB
31.871 kB
react-northstar
Chat		 152.378 kB
45.964 kB
react-northstar
Checkbox		 79.807 kB
25.078 kB
react-northstar
Datepicker		 184.939 kB
56.194 kB
react-northstar
Debug		 8.801 kB
3.594 kB
react-northstar
Design		 36.589 kB
12.067 kB
react-northstar
Dialog		 112.058 kB
33.615 kB
react-northstar
Divider		 76.619 kB
24.129 kB
react-northstar
Dropdown		 196.499 kB
59.455 kB
react-northstar
Embed		 81.477 kB
25.417 kB
react-northstar
Flex		 47.728 kB
15.438 kB
react-northstar
Form		 92.527 kB
28.879 kB
react-northstar
Grid		 70.584 kB
22.278 kB
react-northstar
Header		 74.756 kB
23.461 kB
react-northstar
Image		 73.591 kB
23.329 kB
react-northstar
Input		 88.346 kB
27.78 kB
react-northstar
ItemLayout		 78.231 kB
24.454 kB
react-northstar
Label		 77.92 kB
24.41 kB
react-northstar
Layout		 75.393 kB
23.798 kB
react-northstar
List		 88.493 kB
27.547 kB
react-northstar
Loader		 78.616 kB
24.729 kB
react-northstar
Menu		 126.89 kB
39.872 kB
react-northstar
MenuButton		 161.296 kB
48.883 kB
react-northstar
Pill		 83.722 kB
26.069 kB
react-northstar
Popup		 133.604 kB
41.483 kB
react-northstar
Portal		 58.338 kB
18.852 kB
react-northstar
Provider		 93.138 kB
29.63 kB
react-northstar
RadioGroup		 83.282 kB
26.053 kB
react-northstar
Reaction		 77.28 kB
24.122 kB
react-northstar
Segment		 76.209 kB
23.892 kB
react-northstar
Skeleton		 77.765 kB
24.2 kB
react-northstar
Slider		 84.27 kB
26.737 kB
react-northstar
SplitButton		 176.534 kB
52.63 kB
react-northstar
Status		 76.272 kB
24.05 kB
react-northstar
SvgIcon		 36.823 kB
11.743 kB
react-northstar
Table		 80.796 kB
25.154 kB
react-northstar
Text		 74.114 kB
23.507 kB
react-northstar
TextArea		 74.248 kB
23.492 kB
react-northstar
Toolbar		 173.345 kB
52.08 kB
react-northstar
Tooltip		 108.261 kB
34.482 kB
react-northstar
Tree		 87.855 kB
27.217 kB
react-northstar
Video		 75.411 kB
23.799 kB
react-overflow
hooks only		 12.86 kB
4.825 kB
react-persona
Persona		 57.066 kB
17.821 kB
react-popover
Popover		 126.884 kB
39.803 kB
react-portal
Portal		 13.633 kB
4.869 kB
react-portal-compat
PortalCompatProvider		 7.944 kB
2.588 kB
react-positioning
usePositioning		 26.398 kB
9.539 kB
react-progress
ProgressBar		 17.428 kB
6.899 kB
react-provider
FluentProvider		 23.759 kB
8.657 kB
react-radio
Radio		 32.95 kB
10.252 kB
react-radio
RadioGroup		 15.354 kB
6.265 kB
react-select
Select		 28.609 kB
10.204 kB
react-slider
Slider		 39.949 kB
12.968 kB
react-spinbutton
SpinButton		 36.774 kB
11.789 kB
react-spinner
Spinner		 24.696 kB
8.342 kB
react-switch
Switch		 35.14 kB
11.199 kB
react-table
DataGrid		 165.189 kB
45.907 kB
react-table
Table (Primitives only)		 45.324 kB
14.116 kB
react-table
Table as DataGrid		 136.573 kB
36.817 kB
react-table
Table (Selection only)		 76.334 kB
20.553 kB
react-table
Table (Sort only)		 74.977 kB
20.155 kB
react-tags
InteractionTag		 15.259 kB
6.056 kB
react-tags
Tag		 29.982 kB
9.441 kB
react-tags
TagGroup		 80.556 kB
24.027 kB
react-text
Text - Default		 16.705 kB
6.57 kB
react-text
Text - Wrappers		 19.878 kB
6.897 kB
react-textarea
Textarea		 30.947 kB
10.477 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 35.666 kB
7.453 kB
react-theme
Teams: Light theme		 19.642 kB
5.549 kB
react-timepicker-compat
TimePicker		 104.707 kB
34.558 kB
react-toast
Toast (including Toaster)		 100.198 kB
29.761 kB
react-tooltip
Tooltip		 54.58 kB
19.188 kB
react-utilities
SSRProvider		 180 B
160 B
🤖 This report was generated against fd89630895495f072b46b3cfc8e6de8b255d4e92

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 18, 2024 •
edited

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 617 627 5000
Button mount 291 311 5000
Field mount 1110 1125 5000
FluentProvider mount 699 709 5000
FluentProviderWithTheme mount 80 87 10
FluentProviderWithTheme virtual-rerender 62 69 10
FluentProviderWithTheme virtual-rerender-with-unmount 84 77 10
MakeStyles mount 869 854 50000
Persona mount 1727 1688 5000
SpinButton mount 1341 1386 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 18, 2024 •
edited

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 91 82 1.11:1
RefMinimalPerf.default 124 112 1.11:1
TextMinimalPerf.default 210 190 1.11:1
TableMinimalPerf.default 257 233 1.1:1
HeaderSlotsPerf.default 480 442 1.09:1
AttachmentSlotsPerf.default 666 615 1.08:1
BoxMinimalPerf.default 202 187 1.08:1
ButtonSlotsPerf.default 344 319 1.08:1
TreeWith60ListItems.default 92 85 1.08:1
ListCommonPerf.default 398 372 1.07:1
CardMinimalPerf.default 323 305 1.06:1
FlexMinimalPerf.default 163 154 1.06:1
FormMinimalPerf.default 229 217 1.06:1
ListNestedPerf.default 337 319 1.06:1
PortalMinimalPerf.default 89 84 1.06:1
SegmentMinimalPerf.default 207 196 1.06:1
IconMinimalPerf.default 409 387 1.06:1
ChatDuplicateMessagesPerf.default 163 155 1.05:1
DividerMinimalPerf.default 213 203 1.05:1
ChatMinimalPerf.default 462 445 1.04:1
ProviderMinimalPerf.default 206 198 1.04:1
VideoMinimalPerf.default 461 442 1.04:1
AccordionMinimalPerf.default 95 92 1.03:1
ListMinimalPerf.default 312 302 1.03:1
ListWith60ListItems.default 368 359 1.03:1
StatusMinimalPerf.default 406 394 1.03:1
AnimationMinimalPerf.default 311 304 1.02:1
ButtonOverridesMissPerf.default 667 653 1.02:1
DatepickerMinimalPerf.default 3845 3760 1.02:1
DialogMinimalPerf.default 452 444 1.02:1
DropdownManyItemsPerf.default 400 392 1.02:1
LayoutMinimalPerf.default 204 200 1.02:1
LoaderMinimalPerf.default 199 196 1.02:1
RadioGroupMinimalPerf.default 266 262 1.02:1
SplitButtonMinimalPerf.default 2280 2229 1.02:1
AttachmentMinimalPerf.default 83 82 1.01:1
GridMinimalPerf.default 194 192 1.01:1
ImageMinimalPerf.default 226 224 1.01:1
MenuMinimalPerf.default 511 504 1.01:1
MenuButtonMinimalPerf.default 975 967 1.01:1
PopupMinimalPerf.default 354 352 1.01:1
SliderMinimalPerf.default 751 741 1.01:1
TableManyItemsPerf.default 1121 1105 1.01:1
TreeMinimalPerf.default 484 481 1.01:1
CarouselMinimalPerf.default 267 266 1:1
ChatWithPopoverPerf.default 200 200 1:1
CheckboxMinimalPerf.default 1153 1148 1:1
HeaderMinimalPerf.default 205 206 1:1
RosterPerf.default 1565 1560 1:1
ProviderMergeThemesPerf.default 648 651 1:1
ToolbarMinimalPerf.default 558 560 1:1
TooltipMinimalPerf.default 1291 1296 1:1
AlertMinimalPerf.default 163 164 0.99:1
DropdownMinimalPerf.default 1427 1439 0.99:1
EmbedMinimalPerf.default 1874 1889 0.99:1
InputMinimalPerf.default 540 543 0.99:1
ItemLayoutMinimalPerf.default 718 722 0.99:1
AvatarMinimalPerf.default 109 111 0.98:1
ReactionMinimalPerf.default 216 220 0.98:1
CustomToolbarPrototype.default 1458 1482 0.98:1
SkeletonMinimalPerf.default 192 198 0.97:1
TextAreaMinimalPerf.default 286 296 0.97:1
LabelMinimalPerf.default 218 228 0.96:1

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@marcosmoura marcosmoura enabled auto-merge (squash) March 18, 2024 17:41
@marcosmoura marcosmoura changed the title Revert "feat: add .js file extension to built output + unwrap folder import/export to support native ESM within browser" revert: "feat: add .js file extension to built output + unwrap folder import/export to support native ESM within browser" Mar 18, 2024
@fabricteam
Copy link
Collaborator

fabricteam commented Mar 18, 2024 •
edited

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 643 639 5000
Breadcrumb mount 1684 1651 1000
Checkbox mount 1662 1702 5000
CheckboxBase mount 1461 1464 5000
ChoiceGroup mount 2955 2934 5000
ComboBox mount 637 650 1000
CommandBar mount 6202 6183 1000
ContextualMenu mount 11824 11599 1000
DefaultButton mount 743 746 5000
DetailsRow mount 2210 2138 5000
DetailsRowFast mount 2197 2224 5000
DetailsRowNoStyles mount 1974 1999 5000
Dialog mount 2650 2674 1000
DocumentCardTitle mount 236 223 1000
Dropdown mount 1962 1996 5000
FocusTrapZone mount 1133 1121 5000
FocusZone mount 1084 1059 5000
GroupedList mount 41495 41492 2
GroupedList virtual-rerender 19906 20217 2
GroupedList virtual-rerender-with-unmount 50540 50886 2
GroupedListV2 mount 217 218 2
GroupedListV2 virtual-rerender 201 205 2
GroupedListV2 virtual-rerender-with-unmount 226 223 2
IconButton mount 1066 1050 5000
Label mount 328 346 5000
Layer mount 2709 2777 5000
Link mount 386 380 5000
MenuButton mount 940 949 5000
MessageBar mount 21452 21336 5000
Nav mount 1937 1942 1000
OverflowSet mount 795 793 5000
Panel mount 1767 1756 1000
Persona mount 738 760 1000
Pivot mount 855 861 1000
PrimaryButton mount 847 834 5000
Rating mount 4477 4605 5000
SearchBox mount 900 929 5000
Shimmer mount 1858 1839 5000
Slider mount 1359 1307 5000
SpinButton mount 2876 2885 5000
Spinner mount 383 382 5000
SplitButton mount 1812 1833 5000
Stack mount 401 406 5000
StackWithIntrinsicChildren mount 843 834 5000
StackWithTextChildren mount 2570 2606 5000
SwatchColorPicker mount 6155 6066 5000
TagPicker mount 1471 1450 5000
Text mount 366 372 5000
TextField mount 924 920 5000
ThemeProvider mount 844 831 5000
ThemeProvider virtual-rerender 589 580 5000
ThemeProvider virtual-rerender-with-unmount 1286 1260 5000
Toggle mount 607 606 5000
buttonNative mount 188 193 5000

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@marcosmoura marcosmoura merged commit 4f1b1fd into master Mar 18, 2024
23 checks passed
@spmonahan spmonahan mentioned this pull request Mar 18, 2024
Open
1 task
robertpenner pushed a commit to robertpenner/fluentui that referenced this pull request Apr 11, 2024
@micahgodbolt @robertpenner
revert: "feat: add .js file extension to built output + unwrap folder…
a5334d7 
… import/export to support native ESM within browser" (microsoft#30803)
@khmakoto khmakoto deleted the revert-30770-hotell/pkg/tokens-to-full-esm-build-time branch April 22, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmoura marcosmoura marcosmoura approved these changes

@spmonahan spmonahan spmonahan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
March Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@micahgodbolt @fabricteam @marcosmoura @spmonahan