-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FluentIcon] Minor cleanup and clarification #2038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoituron
requested changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could
dvoituron
requested changes
May 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an Unit Test to validate this new feature?
vnbaaij
previously requested changes
May 13, 2024
vnbaaij
added
chore
Maintenance or non-code work
improvement
A non-feature-adding improvement
labels
May 15, 2024
@dvoituron - I'll clean up and resubmit. |
dvoituron
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π Description
FluentIcon
. Removes invalidwidth
attribute fromSVG
style whenWidth
set tostring.Empty
Width
set tostring.Empty
.π« Issues
For responsive layout, it is preferable to use CSS versus embedding the style in HTML. The
width
of the SVG is embedded unlessFluentIcon
'sWidth
is explicity set tostring.Empty
π©βπ» Reviewer Notes
Any suggestions to the update on the documentation page? I wanted to add some information about this behavior without getting into a specific use case.
π Test Plan
β Checklist
General
Component-specific
β Next Steps