Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Quickstart reference sample functionality, plus UX fixes (accessibility, data binding) #2857

Merged
merged 4 commits into from May 14, 2024

Conversation

adrastogi
Copy link
Contributor

@adrastogi adrastogi commented May 10, 2024

Summary of the pull request

This change adds functionality to the new Quickstart Playground feature to allow implementing extensions to show the user any reference data that went into producing the project.

References and relevant issues

Detailed description of the pull request / Additional comments

In the Quickstart Playground experimental feature, this change exposes a button that the user can click on in the user interface to view the sample directory corresponding to the closest "match" for the user's input prompt (there are supporting changes being made on the Azure extension side that pair with this change). It also includes the supporting scaffolding in the ViewModel to enable this.

As part of this change, we also fix an issue with the View retaining stale data (i.e., progress bar state and last-opened file) from the prior project generation attempt.

This change also addresses some accessibility issues:

  • Added a WrapPanel for ensuring the sample prompts aren't truncated when the window is made smaller horizontally.
  • Added labels for the feedback buttons
  • Added labels for the Open in Visual Studio Code button
  • Making the TextBlock with the generated file content a tab stop

Validation steps performed

I manually ran through the new behavior and verified that I could view the reference sample (the explorer window below was opened via the link under the Generate button).

image

I ran Narrator and Accessibility Insights cleanly, and visually verified the behavior of the controls that are now wrapping.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@adrastogi adrastogi requested a review from manodasanW May 10, 2024 17:36
@adrastogi adrastogi marked this pull request as ready for review May 10, 2024 17:59
@krschau krschau added this to the Dev Home v0.14 milestone May 13, 2024
@adrastogi adrastogi merged commit 4b071cf into main May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants