Inbox Windows Sandbox Environments extension #2752
Conversation
This reverts commit 919083b.
nieubank
changed the title
|
@kvega005 can you add pictures to the PR to show us where the images are being used? |
extensions/WindowsSandboxExtension/Helpers/DependencyChecker.cs
Outdated
Show resolved
Hide resolved
extensions/WindowsSandboxExtension/Providers/WindowsSandboxComputeSystem.cs
Outdated
Show resolved
Hide resolved
|
…005/devhome into user/kevinve/wsb_extension
extensions/WindowsSandboxExtension/Providers/WindowsSandboxComputeSystem.cs
Outdated
Show resolved
Hide resolved
extensions/WindowsSandboxExtension/Providers/WindowsSandboxComputeSystem.cs
Show resolved
Hide resolved
extensions/WindowsSandboxExtension/Providers/WindowsSandboxProvider.cs
Outdated
Show resolved
Hide resolved
extensions/WindowsSandboxExtension/Providers/WindowsSandboxComputeSystem.cs
Outdated
Show resolved
Hide resolved
extensions/WindowsSandboxExtension/Providers/WindowsSandboxComputeSystem.cs
Show resolved
Hide resolved
| ComputeSystemProperty.Create(ComputeSystemPropertyKind.AssignedMemorySizeInBytes, 4294967296), | ||
| ComputeSystemProperty.Create(ComputeSystemPropertyKind.StorageSizeInBytes, 85899345920), | ||
| ComputeSystemProperty.Create(ComputeSystemPropertyKind.UptimeIn100ns, 100), |
There was a problem hiding this comment.
FYI: if you don't provide us with these we won't display them, so its ok to not send these if there is no reliable way to get this data specifically for sandbox
There was a problem hiding this comment.
I am just providing the defaults for Sandbox. Right now, they are hard coded values, but when we implement the create compute system path, I want users to be able to select different options for this.
There was a problem hiding this comment.
Oh I see, then I wonder if its a good idea to make these const variable with a name e.g FourGbInBytes etc so we know at a glance what the value is.
| ComputeSystemProperty.Create(ComputeSystemPropertyKind.AssignedMemorySizeInBytes, 4294967296), | ||
| ComputeSystemProperty.Create(ComputeSystemPropertyKind.StorageSizeInBytes, 85899345920), | ||
| ComputeSystemProperty.Create(ComputeSystemPropertyKind.UptimeIn100ns, 100), |
There was a problem hiding this comment.
Oh I see, then I wonder if its a good idea to make these const variable with a name e.g FourGbInBytes etc so we know at a glance what the value is.
|
I think those last 2 comments I had should be it. Thanks for doing this Kevin! |
Summary of the pull request
Add Windows Sandbox Extension for Dev Home.