Add gridlines to widget graphs #1541
Conversation
| for (var i = 1; i <= NumOfXGridlines; i++) | ||
| { | ||
| var lineElement = new XElement(PolylineElement); | ||
| lineElement.SetAttributeValue(PointsAttr, $"{i * XGridlineHeight},0 {i * XGridlineHeight},{ChartHeight}"); | ||
| lineElement.SetAttributeValue(StyleAttr, LightGrayBoxStyle); | ||
| chart.Add(lineElement); | ||
| } |
There was a problem hiding this comment.
This introduces 'static' vertical gridlines to the chart, which is different from the way the charts are presented in Task Manager. If you view the same chart in Task Manager (say, the CPU usage chart), you'll notice that the vertical gridlines move as time progresses.
In this implementation the vertical gridlines stay in one place, are we alright with that?
There was a problem hiding this comment.
I suspect we want the gridlines to move in the same way Task Manager does, but I've never asked about it.
| @@ -19,8 +19,13 @@ public enum ChartType | |||
|
|
|||
| public const int ChartHeight = 86; | |||
| public const int ChartWidth = 264; | |||
| private const int NumOfYGridlines = 4; | |||
There was a problem hiding this comment.
Why these numbers? What is magical about them?
There was a problem hiding this comment.
We have a bunch of pending questions for Design on what they want here, but since the graphs are so short, 4 lines (one every 20%) seems like it might be the way to go (as opposed to every 10% like in task manager).
Summary of the pull request
Adds gridlines to the widget graphs
References and relevant issues
#1470
Validation steps performed
PR checklist