Batch of checked header changes from CCI 2021-05 #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original header is not available on the system. As agreed with Sulekha. Conditionalizing the installation via CMake might be even better, but that would take some more thought, especially if we still want to test threads_checked.h on systems that don't have threads.h. Note that for the wrapper headers (`foo.h` as opposed to `foo_checked.h`), we reverse the order of the conditionals because we always want to use the `#error` message from `foo.h`, not the one from `foo_checked.h`, which wouldn't make sense if the user originally included `foo.h`. The `#error` message is subject to change in Microsoft's code review.
This applies the change from microsoft#309 to support the common use case for sprintf-like functions with null-terminated arrays.
This is analogous to microsoft#298 for `free` and presumably is safe for the same reason.
Co-authored-by: John Kastner <john@correctcomputation.com> Co-authored-by: mwhicks1 <mwh@correctcomputation.com>
Originally by Mike with no stated reason. We're discussing whether we want to keep it.
This was referenced May 26, 2021
mattmccutchen-cci
changed the title
This was referenced Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously discussed with Sulekha, CCI is preparing to submit a batch of changes to the checked headers that we made in support of our recent porting efforts. I'm going ahead and submitting a draft PR so that I can more easily refer to some of our changes in issues that I'm about to file. Warning: I may still overwrite the commits of the PR via force-push.
One part of the PR that I believe is in final form and that you can go ahead and review if you wish is the change to make
#include-ing a wrapper header an error if the original header does not exist on the system. This change is currently in this commit (though I may overwrite the commit later). It might make sense to make this change into a separate PR (at the cost of some additional overhead) because it is different in nature from all our other changes; let me know if you'd like me to do so.The corresponding draft PR for the tests in the checkedc-clang repository is microsoft/checkedc-clang#1064.