Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4520] Upgrade restify to fix error on Node version 18+ #4528

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4520

Description

This PR upgrades the restify dependency to version 11.1.0 to avoid the error on Node 18+.
It also updates the target in TS bots, as the new version of restify introduced a breaking change.
Additionally, it upgrades botbuilder packages to version 4.20.0 and fixes an eslint issue in the core bot's index.ts.

Specific Changes

  • Updated remaining TS and JS bots to use restify version 11.1.0.
  • Upgraded botbuilder packages to version 4.20.0.
  • Updated the tsconfig.json's target property to es2017.
  • Fixed a lint issue in templates/core/index.ts.

Testing

These images show the generated bots working and the tests in core-with-tests passing.
image

image

@ceciliaavila ceciliaavila requested a review from a team as a code owner August 24, 2023 19:05
@tracyboehrer
Copy link
Member

@ceciliaavila This is failing during the Node 16 tests:

  1. CloudAdapter
    process
    throws exception on expired token:

    AssertionError: expected false to be true

    • expected - actual

    -false
    +true

    at Context. (libraries/botbuilder/tests/cloudAdapter.test.js:153:81)
    at runMicrotasks ()
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

@tracyboehrer tracyboehrer merged commit 3685e5e into main Sep 6, 2023
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/generators branch September 6, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade restify to fix error on Node version 18+
2 participants