Respect ignorePatterns in getPackageInfos #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#761 added error checking for duplicate package names, which accidentally caused issues in
workspace-toolswhen trying to update beachball (see microsoft/workspace-tools#172 (comment)).workspace-toolsis a single package, but it has some other test fixture monorepos inside it. BecausegetScopedPackageshas to scan for non-workspace monorepos before assuming a single package setup,workspace-toolsis getting detected that way and there's an error because several fixture packages share a name.One way to fix this is to respect the
ignorePatternsoption when scanning for packages. This adds a bit of cost but is probably the right thing to do, and will likely help avoid other subtle issues in the future with similar fixture setups.NOTE: The actual fix is simple (in
src/monorepo/getPackageInfos.ts) but a LOT of references needed to be updated due to the signature change.