Ensure beachball properly identifies deleted change-files from same author #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name. Set the similarity index to 100%
nickymunga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this change is to ensure that beachball properly identifies a delete/add for change files done by the same author as
Deletedinstead ofRename.We're specifying a 100% threshold on the similarity index, meaning git will consider a delete/add pair a rename only if 0% of the file has changed.
Beachball is currently using the default threshold of 50%, Meaning if someone deletes a change file, then creates a new one; git will consider this a rename. & `beachball check --disallow-deleted-change-files' will fail to capture this.
Scenario:
Git History:
running
beachball changewith similarity index: 50% :running
beachball checkwith similarity index: 100%