Refactored Azure CLI/PS login process to use Managed Identity #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… VM onboarding to leverage access token. Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
|
Hi janegilring! Thank you for opening this Pull Request. Someone will review it soon. Thank you for committing to making the Azure Arc Jumpstart better. |
Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
… Key Vault deployed using IaC. Signed-off-by: Jan Egil Ring <janegilring@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on modifying the Azure Arc-enabled server configuration scripts to use Managed Identity instead of Service Principal for Azure authentication. The changes enhance security by eliminating the need to manage and rotate secrets for Service Principal.
Here are the top five most significant changes:
Changes to Azure Authentication:
azure_jumpstart_arcbox/artifacts/ArcServersLogonScript.ps1: Removed the usage of Service Principal credentials (spnClientIdandspnClientSecret) and replaced Azure login commands with Managed Identity authentication. [1] [2] [3] [4]azure_jumpstart_arcbox/artifacts/installArcAgent.ps1: Removed the Service Principal parameters (spnClientIdandspnClientSecret) and replaced them with anaccessTokenparameter. The Azure Arc agent connection command was also updated to use the access token for authentication. [1] [2]Removal of Unnecessary Scripts:
azure_jumpstart_arcbox/artifacts/installArcAgentSQLSP.ps1: This script was removed as it was using Service Principal for Azure Arc-enabled SQL Server registration, which is no longer needed.azure_jumpstart_arcbox/artifacts/installArcAgentSQLUser.ps1: This script was removed as it was using Service Principal for Azure Arc-enabled SQL Server registration, which is no longer needed.Resolves #2550