Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log grouping to AzureCLIv2 #19264

Closed

Conversation

MariusStorhaug
Copy link

@MariusStorhaug MariusStorhaug commented Nov 11, 2023

Task name:
AzureCLIv2

Description:
Added Log grouping around the login commands, so that when the context of an account has multiple subscriptions has access to, that will be shown optionally (by extending the log group). Instead of having the long list of contexts, I added a command to show current context if it is selected.

The current implementation here uses console.log('##[group]Name'); and console.log('##[endgroup]');, but I have a PR (microsoft/azure-pipelines-task-lib#994) I am working on to get the functionality into the library (azure-pipelines-task-lib/task). After this is done, the lines would instead say tl.group('Name'); and tl.endgroup();. If you agree to adding the functionality, we should add this as a initial go at it, and then refactor it to use the new functions available in the lib later on.

I also have some auto formatting, cleaning code a bit and fixing alignments.

Documentation changes required:
Not needed

Added unit tests:
N/A

Attached related issue:

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@MariusStorhaug MariusStorhaug marked this pull request as ready for review November 11, 2023 15:43
@MariusStorhaug MariusStorhaug deleted the feat/logGrouping branch April 4, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement]: AzureCLI - Group verbose output
1 participant