Adds parameter to ToolRunner.killChildProcess to specify signal to send #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent-version Add TFS 2017 Update 3 agent version.
Deep Dive on Building Custom Build or Deploy Tasks
* Add task.json schema file * Allow any "connectedService:" type of input * Added the "id" field
…cefiles Allow multiple resource files
Properly escape property value to handle non string types
* Error on multiline secret * v2.3.0
Fix Toolrunner Test "Should handle arguments with quotes properly"
Co-authored-by: Aleksandr Smolyakov <v-alsmo@microsoft.com>
* Added localization pipeline and LocProject.json * Removed en-US * Update localize-pipeline.yml for Azure Pipelines * Update localize-pipeline.yml for Azure Pipelines * Made letter case consistent for languages * LEGO: check in for Localization to temporary branch. (microsoft#703) * LEGO: check in for Localization to temporary branch. (microsoft#714) * LEGO: check in for Localization to temporary branch. (microsoft#720) * Temp renaming * Renamed localization files * Applied enhancements for the localization pipeline (microsoft#733) [skip ci] * [Localization] Fixed localization pipeline issue with already localized strings replaced (microsoft#737) * Localized file check-in by OneLocBuild Task: Build definition ID 10947: Build ID 14646607 Localized file check-in by OneLocBuild Task * LEGO: check in for Localization to temporary branch. (microsoft#740) * LEGO: check in for Localization to temporary branch. (microsoft#741) * LEGO: check in for Localization to temporary branch. (microsoft#742) * LEGO: check in for Localization to temporary branch. (microsoft#743) * Temporary renamed files - to resolve conflicts * Temporary renamed * LEGO: check in for Localization to temporary branch. (microsoft#745) Co-authored-by: csigs <csigs@outlook.com> * LEGO: check in for Localization to temporary branch. (microsoft#746) Co-authored-by: csigs <csigs@outlook.com> * LEGO: check in for Localization to temporary branch. (microsoft#747) Co-authored-by: csigs <csigs@outlook.com> * LEGO: check in for Localization to temporary branch. (microsoft#748) Co-authored-by: csigs <csigs@outlook.com> * Localized file check-in by OneLocBuild Task: Build definition ID 10947: Build ID 14905562 Localized file check-in by OneLocBuild Task * Returned back original names * Removed redundant locale - test * Removed redundant folders * Localized file check-in by OneLocBuild Task: Build definition ID 10947: Build ID 14906155 Localized file check-in by OneLocBuild Task * Returned back changes. Removed redundant * Create PR in OneLocBuild task only on third week of sprint (microsoft#755) * Fix localization pipeline * Add missed change * Added option to disable PR creation * Removing Localize folder Co-authored-by: csigs <csigs@users.noreply.github.com> Co-authored-by: Egor Bryzgalov <v-egbryz@microsoft.com> Co-authored-by: csigs <csigs@outlook.com> Co-authored-by: Nikita Ezzhev <v-niezz@microsoft.com>
* change implicit check for explicit * bump patch version * bump package lock Co-authored-by: Ilya Kuleshov <v-ikuleshov@microsoft.com>
… function (microsoft#790) * fix doc, comment and condition * bumped version * bump version * fix documentation Co-authored-by: Anna Opareva <v-aopareva@microsoft.com> Co-authored-by: Simon Alling <SimonAlling@users.noreply.github.com>
…xceeded" (microsoft#773) * microsoft#667 Error setting resourceFile: "Maximum call stack size exceeded" + Preventing the infinite recustion by not translating warning about missing translation. * Wrong variable in warning output. - Getting rid of unnecessary escaping backslash * Bumping package version * Missing Localization test using mockery The missing file lib.json is simulated via resporting nonexistent file via mockery. Co-authored-by: Martin Šimek <martin.simek@digiteqautomotive.com> Co-authored-by: Anatoly Bolshakov <anatoly.bolshakov@akvelon.com>
* update dependencies
* Add HostException handler * Update error handling for HostException * Update vmImage for windows part * Update way of processing HostException * Change image to win 2019 * Fix naming
* Added new required functions. Return the value instead of the value or undefined. getInputRequired getPathInputRequired getEndpointUrlRequired getEndpointDataParameterRequired getEndpointAuthorizationSchemeRequired getEndpointAuthorizationParameterRequired * Fix undefined in json file * Simplify Required functions. Add tests. Co-authored-by: Keith Banner <keith.banner@inl.gov>
* added formatted proxy URL * version increment
Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> Co-authored-by: Konstantin Tyukalov <52399739+KonstantinTyukalov@users.noreply.github.com>
…t#848) * Update pipeline * Update azure-pipelines.yml * nodeversion as variable Co-authored-by: Andrey Ivanov <v-andivanov@microsoft.com>
Co-authored-by: Andrey Ivanov <v-andivanov@microsoft.com>
DaRosenberg
changed the title
…ted agent, or not. (microsoft#869) * Added function getAgentMode * Function getAgentMode added to documentation * Fix of documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also corrects and clarifies TSDoc comment.
This PR fixes #858 (by correcting method TSDoc wording). In addition, this PR will in allow fixing microsoft/azure-pipelines-tasks#16731 in downstream
BashV3task by making use of the added parameter to send the correct kill signal.Note that this is a non-breaking change; existing code that calls
ToolRunner.killChildProcess()without an argument will continue to see the exact same behavior.