Fix toolrunner line buffering #1030
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FileAndTool Add option to pipe to file and another tool
…crosoft#324) * add optional parameter to getHttpProxyConfig allow bypass filter. * fix
* Missed a couple commands. Catch unmocked commands at compile time. Bump patch version * Need to bump again, had un-synced changes upstream * Strings should be single-quoted * Bump minor version * clarify TODO
* Update schema to support showEnvironmentBlock
* Added missing logging commands * Renamed Write-SetEndpointField function to Write-SetEndpoint
There was a missing comma making the document unusable.
* Removed unsupported lib, added async methods * Update 3rd party library change to async * Format style in ThirdPartyNotice
* Introduce getNodeMajorVersion * Update tests * Update version and changelog * Handle undefined Node version
* Update tasks schema - add removalDate * update removalDate description * update removalDate description
* Update package-lock * Add Invoke-Process function * Add Invoke-Process to members list * Fix $LastExitCode * Revert VstsTaskSdk crlf changes * Revert "refactor: remove Q library from Powershell SDK in favor of native promises (microsoft#944)" This reverts commit 44e727d. * Fix proc exit code * Update Invoke-Process * Fix SupportsWorkingDirectory test * Remove encoding param, update encoding test * Fix path in test * update loc resources * Revert "Revert "refactor: remove Q library from Powershell SDK in favor of native promises (microsoft#944)"" This reverts commit a703a0a. * Gen doc * Update changelog
* simple yampl to create pipeline * Add additional steps into pipeline to publish nuget feed * Upgrade net framework version * Revert csproj changes * Specify msbuild version for old netframework support * Add arch argument to msbuild installation * Bump package version * Use nuspec version directly * Fix downloadFileAsync * rm committed minimatch dll * Move publish steps to job + temp disable it * Move version to package back. Fix encoding * Add publish script * Update tags * update company metadata * Update to publish to powershell gallery --------- Co-authored-by: Konstantin Tyukalov <v-ktyukalov@microsoft.com> Co-authored-by: Konstantin Tyukalov <52399739+KonstantinTyukalov@users.noreply.github.com>
* Update psRunner to fix tests * Add fix for PSModulePath
- Add mockery changes to task-lib version 4
- Added info about task-lib 4.7.0 - Sorted the changelog in reverse chronological order
* Added localization pipeline and LocProject.json * Removed en-US * Update localize-pipeline.yml for Azure Pipelines * Update localize-pipeline.yml for Azure Pipelines * Made letter case consistent for languages * LEGO: check in for Localization to temporary branch. (microsoft#703) * LEGO: check in for Localization to temporary branch. (microsoft#714) * LEGO: check in for Localization to temporary branch. (microsoft#720) * Temp renaming * Renamed localization files * Applied enhancements for the localization pipeline (microsoft#733) [skip ci] * [Localization] Fixed localization pipeline issue with already localized strings replaced (microsoft#737) * Localized file check-in by OneLocBuild Task: Build definition ID 10947: Build ID 14646607 Localized file check-in by OneLocBuild Task * LEGO: check in for Localization to temporary branch. (microsoft#740) * LEGO: check in for Localization to temporary branch. (microsoft#741) * LEGO: check in for Localization to temporary branch. (microsoft#742) * LEGO: check in for Localization to temporary branch. (microsoft#743) * Temporary renamed files - to resolve conflicts * Temporary renamed * LEGO: check in for Localization to temporary branch. (microsoft#745) Co-authored-by: csigs <csigs@outlook.com> * LEGO: check in for Localization to temporary branch. (microsoft#746) Co-authored-by: csigs <csigs@outlook.com> * LEGO: check in for Localization to temporary branch. (microsoft#747) Co-authored-by: csigs <csigs@outlook.com> * LEGO: check in for Localization to temporary branch. (microsoft#748) Co-authored-by: csigs <csigs@outlook.com> * Localized file check-in by OneLocBuild Task: Build definition ID 10947: Build ID 14905562 Localized file check-in by OneLocBuild Task * Returned back original names * Removed redundant locale - test * Removed redundant folders * Localized file check-in by OneLocBuild Task: Build definition ID 10947: Build ID 14906155 Localized file check-in by OneLocBuild Task * Returned back changes. Removed redundant * Create PR in OneLocBuild task only on third week of sprint (microsoft#755) * Fix localization pipeline * Add missed change * Added option to disable PR creation * Add OneLocBuild removal to the localization pipeline (microsoft#804) * Add OneLocBuild removal to the pipeline * fix ignore error to double if Co-authored-by: Ilya Kuleshov <v-ikuleshov@microsoft.com> * Localization update (microsoft#802) * Removing Localize folder * Revert "Removing Localize folder" Co-authored-by: Ilya Kuleshov <v-ikuleshov@microsoft.com> * Removed OneLocBuild folder * Move notifications about Task-lib Localization PR from Slack to MS Teams - Part 1 (microsoft#816) * Localized file check-in by OneLocBuild Task: Build definition ID 10947: Build ID 18673037 (microsoft#879) * Juno: check in to lego/hb_a4aa9cc4-603b-418e-91f1-700184175625_20221105085105779. (microsoft#881) * Juno: check in to lego/hb_a4aa9cc4-603b-418e-91f1-700184175625_20221106085044954. (microsoft#882) * Localized file check-in by OneLocBuild Task: Build definition ID 10947: Build ID 18697074 (microsoft#883) * Update LocProject file * Update LocProject * Remove lowercase loc strings on windows * renormalize resjson line endings * Juno: check in to lego/hb_a4aa9cc4-603b-418e-91f1-700184175625_20230823085002328. (microsoft#963) * Juno: check in to lego/hb_a4aa9cc4-603b-418e-91f1-700184175625_20230824085133912. (microsoft#964) * Localized file check-in by OneLocBuild Task: Build definition ID 10947: Build ID 22418181 (microsoft#970) * Juno: check in to lego/hb_a4aa9cc4-603b-418e-91f1-700184175625_20231018084934541. (microsoft#981) * Juno: check in to lego/hb_a4aa9cc4-603b-418e-91f1-700184175625_20231019084924530. (microsoft#984) * Localized file check-in by OneLocBuild Task: Build definition ID 10947: Build ID 23093005 (microsoft#986) * Removing Localize and OneLocBuild folder * Fixed typo --------- Co-authored-by: Anatolii Bolshakov (Akvelon INC) <v-anbols@microsoft.com> Co-authored-by: csigs <csigs@users.noreply.github.com> Co-authored-by: Egor Bryzgalov <v-egbryz@microsoft.com> Co-authored-by: Anatoly Bolshakov <anatoly.bolshakov@akvelon.com> Co-authored-by: csigs <csigs@outlook.com> Co-authored-by: Nikita Ezzhev <v-niezz@microsoft.com> Co-authored-by: kuleshovilya <87485027+kuleshovilya@users.noreply.github.com> Co-authored-by: Ilya Kuleshov <v-ikuleshov@microsoft.com> Co-authored-by: Denis Tikhomirov <90906678+denis-tikhomirov@users.noreply.github.com> Co-authored-by: KonstantinTyukalov <v-ktyukalov@microsoft.com> Co-authored-by: Konstantin Tyukalov <52399739+KonstantinTyukalov@users.noreply.github.com> Co-authored-by: Dmitrii Bobreshev <106314398+DmitriiBobreshev@users.noreply.github.com> Co-authored-by: Dmitrii Bobreshev (Akvelon INC) <v-bobreshevd@microsoft.com>
* Adds RecallOn* file attributes Fixes microsoft#763 * Update powershell/CompiledHelpers/VstsTaskSdk.cs --------- Co-authored-by: Denis Rumyantsev <v-denisr@microsoft.com>
…unctions (microsoft#1009) * Added the IssueSource parameter for the PowerShell SDK and the Node SDK. * Bump package versions.
* Added the issue source for uncaught exception handling. * Package version bump.
* Added issue sources for all internal issues. * Bump package versions.
…1014) - Added write permissions in gh workflow
* Add node tl feature helper * Fix typescript err * Update changelog * Bump package version * node: Format debug message * powershell: Add Get-PipelineFeature * powershell: Bump version to 0.19.0 * Reset InputFunctions encoding
* 1ES Pipelines Template Adoption - Added 1Es templates for azure-pipelines-extensions.yml - Changed pools for windows/ubuntu to 1ES pools * 1ES Pipelines Template Adoption - Guardian set up * 1ES Pipelines Template Adoption - Guardian set up * 1ES Pipelines Template Adoption - Guardian set up * 1ES Pipelines Template Adoption - Guardian set up * 1ES Pipelines Template Adoption - swith to 1ESPtTfsAgentBuildPool1 pool * 1ES Pipelines Template Adoption - swith to 1ES-ABTT-Shared-Pool pool * 1ES Pipelines Template Adoption - swith to 1ES-ABTT-Shared-Pool pool
Added task SDK token support; added a default value for the issue source property.
* Added dotnet build step for Windows * Fixed dotnet cli task inputs * Added VS build task * Added VS build task * Upgraded to .netstandard2.1 * Switched to dotnet CLI task * Removed reference to .NET Framework * .NET Standard for all configurations * Fixed some default behavior during the build phase
The _processLineBuffer method is incorrectly buffering line data since the buffer is being passed as a string and thus changes to the buffer preformed in the method are not persisted. The fix is to use an object with a string property as the buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_processLineBufferneeds to buffer data between method calls but the variable it is using as its buffer is a string parameter and thus goes out of scope at the end of the method. To ensure the buffer is persisted across calls it needs to be an object.