Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SignalSection: "System / Critical" and IsClosable="False" #1532

Merged
merged 1 commit into from May 15, 2024
Merged

Update SignalSection: "System / Critical" and IsClosable="False" #1532

merged 1 commit into from May 15, 2024

Conversation

Jay-o-Way
Copy link
Contributor

@Jay-o-Way Jay-o-Way commented May 5, 2024 •
edited

Description

  • Updated text to match content: "System / Critical Background". Fixing a typo.
  • Also set IsClosable="False" on the InfoBar, because when it's closed, user needs to nav to the page again to see it.

Motivation and Context

Incorrect text.
Illogical use case for InfoBar.

Screenshots (if appropriate):

imageimage

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

niels9001
niels9001 approved these changes May 5, 2024
View reviewed changes
Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks!

@Jay-o-Way Jay-o-Way changed the title Update SignalSection.xaml: "System / Critical" Update SignalSection: "System / Critical" and IsClosable="False" May 5, 2024
@niels9001
Copy link
Collaborator

/azp run

1 similar comment
@niels9001
Copy link
Collaborator

/azp run

@karkarl karkarl merged commit 10e8326 into microsoft:main May 15, 2024
2 checks passed
@Jay-o-Way Jay-o-Way deleted the System-Critical branch May 15, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niels9001 niels9001 niels9001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jay-o-Way @niels9001 @karkarl