chore: Adding Spark35 support #2172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrendanWalsh
force-pushed
the
brwals/spark35
branch
from
4960c33
to
6443687
Compare
BrendanWalsh
force-pushed
the
brwals/spark35
branch
from
0510590
to
b2de5f3
Compare
| @@ -3,7 +3,7 @@ FROM mcr.microsoft.com/oss/mirror/docker.io/library/ubuntu:20.04 | |||
| ARG SYNAPSEML_VERSION=1.0.2 | |||
| ARG DEBIAN_FRONTEND=noninteractive | |||
|
|
|||
| ENV SPARK_VERSION=3.4.1 | |||
| ENV SPARK_VERSION=3.5.0 | |||
There was a problem hiding this comment.
nit: we should use 3.5.1 instead of 3.5.0
| @@ -7,7 +7,7 @@ import scala.xml.transform.{RewriteRule, RuleTransformer} | |||
| import scala.xml.{Node => XmlNode, NodeSeq => XmlNodeSeq, _} | |||
|
|
|||
| val condaEnvName = "synapseml" | |||
| val sparkVersion = "3.4.1" | |||
| val sparkVersion = "3.5.0" | |||
BrendanWalsh
requested review from
svotaw,
memoryz,
eisber and
imatiach-msft
as code owners
BrendanWalsh
force-pushed
the
brwals/spark35
branch
from
6d8b645
to
17ed2a8
Compare
BrendanWalsh
force-pushed
the
brwals/spark35
branch
from
17ed2a8
to
b64da83
Compare
BrendanWalsh
force-pushed
the
brwals/spark35
branch
2 times, most recently
from
049806a
to
d5098e3
Compare
BrendanWalsh
force-pushed
the
brwals/spark35
branch
from
d8bd2dc
to
12a8a39
Compare
Acrolinx ScorecardsA minimum Acrolinx score of 80 is required. Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology.
More information about Acrolinx |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2172 +/- ##
==========================================
- Coverage 85.95% 85.90% -0.06%
==========================================
Files 329 329
Lines 17086 17086
Branches 1515 1515
==========================================
- Hits 14687 14678 -9
- Misses 2399 2408 +9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Spark 3.5
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
Briefly describe the changes included in this Pull Request.
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentationfolder.Make sure you choose the correct class
estimators/transformersand namespace.DocTablepoints to correct API link.yarn run startto make sure the website renders correctly.<!--pytest-codeblocks:cont-->before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTestsjob pass in the pipeline.