New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not merge: move dependencies to databricks utils #1980
base: master
Are you sure you want to change the base?
Conversation
Hey @imatiach-msft 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
dfab013
to
41ced8d
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary by GPT-4
The changes in the code include:
- Updating the AdbRuntime version from "10.4.x-scala2.12" to "12.2.x-scala2.12".
- Adding new packages to be installed: raiwidgets, itsdangerous==2.0.1, hyperopt, and scikit-learn.
- Moving the installation of raiwidgets and interpret-community packages to an earlier point in the notebook for "IsolationForest - Multivariate Anomaly Detection" and "Interpretability - Explanation Dashboard".
- Adding instructions for installing raiwidgets and interpret-community packages when running on Synapse Analytics.
These changes seem to be related to updating package versions, adding new dependencies, and improving compatibility with Synapse Analytics environments.
Suggestions
No suggestions are needed as the changes in this PR are clear and well-implemented.
Codecov Report
@@ Coverage Diff @@
## master #1980 +/- ##
==========================================
- Coverage 87.02% 79.99% -7.03%
==========================================
Files 305 305
Lines 15993 15993
Branches 839 839
==========================================
- Hits 13918 12794 -1124
- Misses 2075 3199 +1124 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -31,7 +31,7 @@ object DatabricksUtilities { | |||
val Region = "eastus" | |||
val PoolName = "synapseml-build-10.4" | |||
val GpuPoolName = "synapseml-build-10.4-gpu" | |||
val AdbRuntime = "10.4.x-scala2.12" | |||
val AdbRuntime = "12.2.x-scala2.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think scala2.12
begs for its own val
?
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"First we install required dependencies and import the packages and define some UDFs we will need later.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: too many and
s
"metadata": {}, | ||
"source": [ | ||
"First we install required dependencies and import the packages and define some UDFs we will need later.\n", | ||
"When running Synapse Analytics, please follow instructions here [Package management - Azure Synapse Analytics | Microsoft Docs](https://docs.microsoft.com/en-us/azure/synapse-analytics/spark/apache-spark-azure-portal-add-libraries) to install [\"raiwidgets\"](https://pypi.org/project/raiwidgets/) and [\"interpret-community\"](https://pypi.org/project/interpret-community/) packages." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: replace here
with in
Related Issues/PRs
#xxx
What changes are proposed in this pull request?
move dependencies to databricks utils
How is this patch tested?
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?
website/docs/documentation
folder.Make sure you choose the correct class
estimators/transformers
and namespace.DocTable
points to correct API link.yarn run start
to make sure the website renders correctly.<!--pytest-codeblocks:cont-->
before each python code blocks to enable auto-tests for python samples.WebsiteSamplesTests
job pass in the pipeline.