Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not merge: move dependencies to databricks utils #1980

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

imatiach-msft
Copy link
Contributor

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

move dependencies to databricks utils

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Hey @imatiach-msft 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary by GPT-4

The changes in the code include:

  1. Updating the AdbRuntime version from "10.4.x-scala2.12" to "12.2.x-scala2.12".
  2. Adding new packages to be installed: raiwidgets, itsdangerous==2.0.1, hyperopt, and scikit-learn.
  3. Moving the installation of raiwidgets and interpret-community packages to an earlier point in the notebook for "IsolationForest - Multivariate Anomaly Detection" and "Interpretability - Explanation Dashboard".
  4. Adding instructions for installing raiwidgets and interpret-community packages when running on Synapse Analytics.

These changes seem to be related to updating package versions, adding new dependencies, and improving compatibility with Synapse Analytics environments.

Suggestions

No suggestions are needed as the changes in this PR are clear and well-implemented.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #1980 (dca6b66) into master (fc5d699) will decrease coverage by 7.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1980      +/-   ##
==========================================
- Coverage   87.02%   79.99%   -7.03%     
==========================================
  Files         305      305              
  Lines       15993    15993              
  Branches      839      839              
==========================================
- Hits        13918    12794    -1124     
- Misses       2075     3199    +1124     

see 39 files with indirect coverage changes

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@imatiach-msft
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -31,7 +31,7 @@ object DatabricksUtilities {
val Region = "eastus"
val PoolName = "synapseml-build-10.4"
val GpuPoolName = "synapseml-build-10.4-gpu"
val AdbRuntime = "10.4.x-scala2.12"
val AdbRuntime = "12.2.x-scala2.12"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think scala2.12 begs for its own val?

"cell_type": "markdown",
"metadata": {},
"source": [
"First we install required dependencies and import the packages and define some UDFs we will need later.\n",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: too many ands

"metadata": {},
"source": [
"First we install required dependencies and import the packages and define some UDFs we will need later.\n",
"When running Synapse Analytics, please follow instructions here [Package management - Azure Synapse Analytics | Microsoft Docs](https://docs.microsoft.com/en-us/azure/synapse-analytics/spark/apache-spark-azure-portal-add-libraries) to install [\"raiwidgets\"](https://pypi.org/project/raiwidgets/) and [\"interpret-community\"](https://pypi.org/project/interpret-community/) packages."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: replace here with in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants