fix: restore loglevel in TestBase.withoutLogging #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @BrendanWalsh 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
| // Spark doesn't expose a getLogLevel, but setLogLevel is a thin wrapper around log4j | ||
| // so get the current logLevel directly from log4j | ||
| // https://github.com/apache/spark/blob/4be566062defa249435c4d72eb106fe7b933e023/core/src/main/scala/org/apache/spark/util/Utils.scala#L2330 | ||
| val currentLevel = org.apache.log4j.Logger.getRootLogger().getLevel |
There was a problem hiding this comment.
What log level is this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sc.setLogLevel is a thin wrapper around log4j, so we can retrieve the current loglevel from log4j instead of resetting to "WARN"
https://github.com/apache/spark/blob/4be566062defa249435c4d72eb106fe7b933e023/core/src/main/scala/org/apache/spark/util/Utils.scala#L2330