Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update_snapshot arg to load_instrument #6075

Merged
merged 4 commits into from
May 19, 2024

Conversation

thangleiter
Copy link
Contributor

Station.add_component() allows the keyword argument update_snapshot. This change modifies the load_instrument() method to also accept this keyword and pass it on to add_component() when calling it.

It is passed through to add_component()
@thangleiter thangleiter requested a review from a team as a code owner May 15, 2024 13:59
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.62%. Comparing base (e606790) to head (8ce4f73).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6075      +/-   ##
==========================================
+ Coverage   67.55%   67.62%   +0.07%     
==========================================
  Files         351      351              
  Lines       30492    30557      +65     
==========================================
+ Hits        20598    20664      +66     
+ Misses       9894     9893       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen
Copy link
Collaborator

Thanks @thangleiter looks good. Could you add a newsfragment describing the change as detailed in the pull request template

@jenshnielsen
Copy link
Collaborator

@thangleiter I would recommend you installing the precommit hooks that qcodes uses. This should safe you some time on these error from darker and the precommit hooks. See https://pre-commit.com/

auto-merge was automatically disabled May 18, 2024 12:46

Head branch was pushed to by a user without write access

@thangleiter
Copy link
Contributor Author

They are installed... no complaints locally. Anyhow, I made the change manually.

@jenshnielsen jenshnielsen added this pull request to the merge queue May 19, 2024
Merged via the queue into microsoft:main with commit 2db9cc4 May 19, 2024
20 checks passed
@thangleiter thangleiter deleted the enh/station_load_instrument branch May 19, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants