-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow parameter contexts for uninitialized parameters #6074
Merged
jenshnielsen
merged 8 commits into
microsoft:main
from
qutech:bugfix/parameter_context_without_initial_value
May 19, 2024
Merged
Allow parameter contexts for uninitialized parameters #6074
jenshnielsen
merged 8 commits into
microsoft:main
from
qutech:bugfix/parameter_context_without_initial_value
May 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for params with validators but no initial value and get_cmd
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6074 +/- ##
==========================================
+ Coverage 67.55% 67.62% +0.07%
==========================================
Files 351 351
Lines 30492 30560 +68
==========================================
+ Hits 20598 20667 +69
+ Misses 9894 9893 -1 ☔ View full report in Codecov by Sentry. |
jenshnielsen
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, using the
set_to
context fails on exit for parameters whose value does not pass the set parser or validator. The only -- but common -- case where this happens are uninitialized parameters, in which case the value isNone
.This change catches exceptions when setting the original value and then sets the cache value instead. The exception catch is very broad, but as far as I can tell, validators can raise any kind of exception they like. Only doing this if
original_value
isNone
might be a bit safer -- are there other cases?