Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parameter contexts for uninitialized parameters #6074

Conversation

thangleiter
Copy link
Contributor

Currently, using the set_to context fails on exit for parameters whose value does not pass the set parser or validator. The only -- but common -- case where this happens are uninitialized parameters, in which case the value is None.

This change catches exceptions when setting the original value and then sets the cache value instead. The exception catch is very broad, but as far as I can tell, validators can raise any kind of exception they like. Only doing this if original_value is None might be a bit safer -- are there other cases?

@thangleiter thangleiter requested a review from a team as a code owner May 15, 2024 13:40
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.62%. Comparing base (e606790) to head (c6f543a).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6074      +/-   ##
==========================================
+ Coverage   67.55%   67.62%   +0.07%     
==========================================
  Files         351      351              
  Lines       30492    30560      +68     
==========================================
+ Hits        20598    20667      +69     
+ Misses       9894     9893       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue May 19, 2024
Merged via the queue into microsoft:main with commit c41120b May 19, 2024
20 checks passed
@thangleiter thangleiter deleted the bugfix/parameter_context_without_initial_value branch May 19, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants