Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSRC 67460: Fix file ownership for NPM files #820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MSRC 67460: Fix file ownership for NPM files #820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions installbuilder/datafiles/Base_DSC.data
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,7 @@ chown root:root /opt/microsoft/${{SHORT_NAME}}/Scripts/OMSServiceStatAll.sh
chown root:root /opt/microsoft/${{SHORT_NAME}}/Scripts/OMSYumUpdates.sh
chown root:root /opt/microsoft/${{SHORT_NAME}}/Scripts/OMSZypperUpdates.sh
chown root:root /opt/microsoft/${{SHORT_NAME}}/Scripts/OMSAptUpdates.sh
chown root:root /opt/microsoft/${{SHORT_NAME}}/Scripts/NPMAgentBinaryCap.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, "NPMAgentBinaryCap.sh" script might not have been created as "nxOMSAgentNPMConfig" DSC module is an optional module. So, it would be better if we modify the owner permissions of the above script in "npm_startup.sh" script in which "NPMAgentBinaryCap.sh" creation happens.

# Reset file ownership at /opt/microsoft/omsagent/plugin
chown root:root /opt/microsoft/omsagent/plugin/tailfilereader.rb

Expand Down