Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed case where comparing stdout bytes to a string issue 797 #798

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jineshcodes
Copy link
Contributor

Incident ID or link #797
Issue summary Configurations with nxService resource where the service falls under servicemd fails for Python3 during get_marshall()
Impact All distros running on python 3 will not be able to use configurations which try to set service that falls under servicemd for nxService resource. The service will not crash but fail gracefully.
Root cause The reason the get_mashall() is failing is because of a comparison  between string and stdout. For python 3 stdout can be in bytes. Issue in line: https://github.com/microsoft/PowerShell-DSC-for-Linux/blob/v1.2.0-0/Providers/Scripts/3.x/Scripts/nxService.py#L858
Reason for not getting caught before release This scenario was not covered as a part of test suite or manual tests. Manual tests were only done for major scenarios and not for corner cases.

@jineshcodes jineshcodes changed the title Fixed case where comparing stdout bytes to a string issue #797 Fixed case where comparing stdout bytes to a string issue 797 May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant