New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSShortName for Oracle Linux #794
Open
nikhim-um
wants to merge
21
commits into
microsoft:master
Choose a base branch
from
nikhim-um:nikhim-um/Powershell-DSC-UM
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
OSShortName for Oracle Linux #794
nikhim-um
wants to merge
21
commits into
microsoft:master
from
nikhim-um:nikhim-um/Powershell-DSC-UM
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for Update Management support for Oracle Linux. setting os short name as "Oracle" directly till it gets fixed at /etc/opt/microsoft/scx/conf/scx-release
fixed indentation
Workaround to fix os short name for Oracle Linux as "Oracle" till /etc/opt/microsoft/scx/conf/scx-release has proper OSShortName field.
shortName for Oracle. indentation fix
fixing indentation
Changing Version from 3.56 to 3.57
assing
approved these changes
Apr 28, 2021
@nikhim-um nit the indenting looks screwed up at least in github view. consider fixing formatting. otherwise LGTM |
hestolz
reviewed
Apr 29, 2021
@@ -541,7 +541,7 @@ nxOMSGenerateInventoryMof: | |||
|
|||
nxOMSPlugin: | |||
rm -rf output/staging; \ | |||
VERSION="3.57"; \ | |||
VERSION="3.58"; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seth Rait just made changes to nxOMSPlugin and version is bumped to 3.58. Please work with him to ensure smooth rollout of combined changes
Workaround for Update Management support for Oracle Linux. setting os short name as "Oracle" directly till it gets fixed at /etc/opt/microsoft/scx/conf/scx-release
fixed indentation
Workaround to fix os short name for Oracle Linux as "Oracle" till /etc/opt/microsoft/scx/conf/scx-release has proper OSShortName field.
shortName for Oracle. indentation fix
fixing indentation
Changing Version from 3.56 to 3.57
…im-um/PowerShell-DSC-for-Linux into nikhim-um/Powershell-DSC-UM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently /etc/opt/microsoft/scx/conf/scx-release do not have proper short name for oracle linux OSs. To support update management linux classification for Oracle Linux, adding OSShort Name for Oracle Linux