Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Makefile to respect version provided in Build Repo #673

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Makefile to respect version provided in Build Repo #673

wants to merge 1 commit into from

Conversation

Bhargava-Chary-Chollaty
Copy link
Collaborator

Remove version hardcoding and pick version from build repo.

@Bhargava-Chary-Chollaty Bhargava-Chary-Chollaty marked this pull request as ready for review March 10, 2020 03:52
@chsamala
Copy link
Contributor

Please test whether the complete build is passing or not and make sure that output bits generated with right version as per configuration.

chsamala
chsamala approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@chsamala chsamala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test as mentioned.

@jineshcodes jineshcodes self-requested a review March 10, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jineshcodes jineshcodes jineshcodes approved these changes

@chsamala chsamala chsamala approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Bhargava-Chary-Chollaty @chsamala @jineshcodes @bhargavacharychollaty